Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file option & cleanup before imports #600

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Sep 2, 2023

Fixes #596

Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
Signed-off-by: Omkar Phansopkar <omkarphansopkar@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra changed the base branch from v4.0-react-typescript to feature/unittests September 25, 2023 08:49
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @OmkarPh
Closing feature works great.

close_button

The UI is a bit basic at the moment and can be improved potentially, but that's a refinement.

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Sep 25, 2023

LGTM! Thanks @OmkarPh Closing feature works great.

close_button

The UI is a bit basic at the moment and can be improved potentially, but that's a refinement.

yeah, right now there's only this button, keyboard shortcut & menu item
We can think about more accessible ways

@AyanSinhaMahapatra
Copy link
Member

Please merge @OmkarPh 😄

@OmkarPh OmkarPh merged commit 8688efd into feature/unittests Oct 2, 2023
7 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the feature/closefile branch October 25, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants