Add OSS-Index DataSource #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshav-space
force-pushed
the
oss_index_datasource
branch
from
ac83f14
to
576330b
Compare
keshav-space
force-pushed
the
oss_index_datasource
branch
from
477921c
to
bcc3fe0
Compare
keshav-space
force-pushed
the
oss_index_datasource
branch
from
bcc3fe0
to
e639b5e
Compare
TG1999
requested changes
Sep 5, 2022
vulntotal/datasources/oss_index.py
Outdated
|
|
||
|
|
||
| def parse_advisory(component) -> Iterable[VendorData]: | ||
| response = component[0] |
There was a problem hiding this comment.
please assert if length of component is 1 before accesing it
vulntotal/datasources/oss_index.py
Outdated
|
|
||
| def parse_advisory(component) -> Iterable[VendorData]: | ||
| response = component[0] | ||
| if response["vulnerabilities"]: |
There was a problem hiding this comment.
Use more pythonic way to get objects from dictionary for example
Suggested change
| if response["vulnerabilities"]: | |
| if response.get("vulnerabilities"): |
|
Add doctsrings for all the functions and also add doctests/ unit tests for functions which have not been tested at all |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #820