Step3. 3단계 - 로또(2등) #1125
Merged
Step3. 3단계 - 로또(2등) #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byungkyu-ju
commented
Dec 17, 2020
byungkyu-ju
commented
Dec 17, 2020
byungkyu-ju
commented
Dec 17, 2020
byungkyu-ju
commented
Dec 17, 2020
hongsii
approved these changes
Dec 17, 2020
| (oldValue, newValue) -> oldValue, LinkedHashMap::new)); | ||
| private List<Prize> awards(LottoTickets userLottoTickets, WinningLottoTicket winnerLottoTicket) { | ||
| return userLottoTickets.getLottoTickets().stream() | ||
| .map(lottoTicket -> matchTicketToPrize(lottoTicket, winnerLottoTicket)) |
There was a problem hiding this comment.
필드를 지닌 객체를 통해 로직이 처리되도록 winnerLottoTicket 로 메시지를 보내도록 바꿔보면 어떨까요?
Prize prize = winnerLottoTicket.match(lottoTicket)
Comment on lines
+28
to
+29
| return Arrays.stream(values()).filter(prize -> prize.isEqualMatchCount(count)) | ||
| .filter(prize -> !prize.equals(SECOND) || isMatchBonus) |
There was a problem hiding this comment.
Stream은 한 줄에 하나의 처리만 하도록 구현하면 가독성을 향상시킬 수 있습니다.
Suggested change
| return Arrays.stream(values()).filter(prize -> prize.isEqualMatchCount(count)) | |
| .filter(prize -> !prize.equals(SECOND) || isMatchBonus) | |
| return Arrays.stream(values()) | |
| .filter(prize -> prize.isEqualMatchCount(count)) | |
| .filter(prize -> !prize.equals(SECOND) || isMatchBonus) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.