[나무] TodoList CRUD #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 파일 끝 endline 추가 https://blog.coderifleman.com/2015/04/04/text-files-end-with-a-newline/ - 불필요 코드 삭제 - let -> const
- 지난 피드백 적용하면서 수정 덜된부분 수정 - TodoCount에서는 count만 받도록 수정
- handle conflict
ganeodolu
reviewed
Aug 13, 2020
js/TodoList.js
Outdated
| @@ -58,7 +60,7 @@ function TodoList($todoList, data, removeItem){ | |||
| this.render = () => { | |||
| let result = '' | |||
| this.data.map(({ text }, index) => { | |||
| result += `<li class="todo-item" data-index="${index}"> | |||
| result += `<li class="todo-item ${data[index].isCompleted == true? 'completed' : ''}" data-index="${index}"> | |||
| <div class="view"> | |||
| <input class="toggle" type="checkbox" /> | |||
There was a problem hiding this comment.
63번째줄에서 isCompleted 체크한 것처럼 토글에서도 적용하면 삭제시 체크박스 해제를 방지할 수 있을 것 같습니다. 🐸
<input class="toggle" type="checkbox" ${data[index].isCompleted ? 'checked' : ''} />
There was a problem hiding this comment.
악 감사합니다 ㅠㅠㅠㅠ 이걸 몰랐다니!! 바로 적용하겠씁니다 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1주차 - TodoList CRUD
🎯 요구사항
🎯🎯 심화 요구사항
✨ 그냥 해보고싶어서 해본것
🐞버그
느낀점
더 효과적으로 참고하기 위해 돌려보면서 동작을 확인하는 방식으로 해보려 합니다!