-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BattleNet Provider doesn't work (few issues) #4013
Comments
* Fixes: #4013 * Update packages/next-auth/src/providers/battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com> * Update packages/next-auth/src/providers/battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com> * Update packages/next-auth/src/providers/battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com> * Apply suggestions from code review * Update battlenet.ts * Update battlenet.ts * Update battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com>
I have the same issue for my FacebookProvider how did you fix it @Stono ? |
Check #4015 @devaublanc - basically rewrote the provider. The same exists in the bungie provider too. Honestly i don't think many of the next-auth out of the box providers work any more as they're drifted from the providers tech implementation. |
@Stono you might be right, and we would need all the help we can get to keep them up to date. See #2524 for more information. I tried my best to update/manually test as many of them as possible so far. Unfortunately, it's nearly impossible to test them in CI as most providers disallow bots. If you have a suggestion on how to do better, we would like to hear! 🙏 |
Any updates on this? I have the same issue and did the same troubleshoot, which had the same results. |
* Fixes: nextauthjs#4013 * Update packages/next-auth/src/providers/battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com> * Update packages/next-auth/src/providers/battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com> * Update packages/next-auth/src/providers/battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com> * Apply suggestions from code review * Update battlenet.ts * Update battlenet.ts * Update battlenet.ts Co-authored-by: Balázs Orbán <info@balazsorban.com>
Provider type
Battlenet
Environment
Reproduction URL
Describe the issue
Hi,
The Battlenet provider doesn't seem to work. I've come across two issues so far.
The first is:
This seems to be resolved by setting
idToken: true
on the provider.Once past this part, we get:
The code appears to be comparing the
iss
from the JWT response to the provider issuer, and they don't match:Not sure how to resolve that one...
If i just hack that part out, the next error I get is:
Which again looking at the Issuer makes sense? It's almost like the
Issuer
object is missing key information that's required to validate the JWT.How to reproduce
Just configure the Battlenet provider:
Expected behavior
It should work
The text was updated successfully, but these errors were encountered: