-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(email) allow for custom mail implementations #10376
feat(email) allow for custom mail implementations #10376
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@JipSterk is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
||
return { | ||
id: "nodemailer", | ||
type: "email", | ||
name: "Nodemailer", | ||
server: { host: "localhost", port: 25, auth: { user: "", pass: "" } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i couldn't figure out why this server object was needed outside of development purposes
I think this PR is no longer necessary. We shipped multiple http request Email providers (which can be extended). Can you check out these links and let me know if that covers it for yuo?
|
hi @ndmom thanks for the suggestion, i haven’t stumbled upon this page in the docs and it seems like this is exactly what i want! however when i define an object with the same properties the typescript compiler will complain that the following properties are missing:
|
@JipSterk which object are you referring to that's giving you TS issues? Could you provide some code example or point to the relevant piece in the example pages I linked to above? Also what are you using |
that would be EmailConfig it requires the properties mentioned above which are: |
@JipSterk thanks for pointing this out, it looks like both could use a bit of updating.
I've updated the guide to show the use of I dont thinkt he changes to the EDIT: Just noticed that |
d79b484
to
9515f27
Compare
☕️ Reasoning
currently solutions using a custom configuration of
sendVerificationRequest
for thenodemailer
provider still require aserver
config object passed even though it's type is not mandatory which is not need for implementations that for example use a sdk likeaws-ses
orreact-email
🧢 Checklist
🎫 Affected issues
📌 Resources