fix(jwt): argument salt should not be required in getToken method of @auth/core/jwt
#10463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Someone is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
jdmnk
changed the title
salt should not be required in getToken method of @auth/core/jwtsalt should not be required in getToken method of @auth/core/jwt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
In
getTokenfunction of the@auth/core/jwtlib, thesaltargument is required even though it has a default value set in the function body. Given that the developer is likely not aware of which salt value is used for encoding jwt, it would make sense to make it optional since the default value will work for most cases.I have fixed the issue by changing salt to be a
Partial<Pick<>>- this makes it optional and retains the full type reference at the same time (e.g. comment onsaltproperty from source interface).🧢 Checklist
🎫 Affected issues
Relates to: #9133 #10293
📌 Resources