fix(ts): reduce public type surface #10557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
…uth into docs/reduce-ts-surface
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10557 +/- ##
==========================================
+ Coverage 38.53% 40.58% +2.05%
==========================================
Files 171 172 +1
Lines 27080 27644 +564
Branches 1117 1174 +57
==========================================
+ Hits 10435 11220 +785
+ Misses 16645 16424 -221 ☔ View full report in Codecov by Sentry. |
ndom91
changed the title
hillac
pushed a commit
to hillac/next-auth
that referenced
this pull request
Jun 19, 2024
* fix(ts): reudce public type surface * change * fix * simplify * simplify * simplify * chore: update links in index.ts * mark `isClientError` as internal --------- Co-authored-by: Nico Domino <yo@ndo.dev>
JipSterk
pushed a commit
to JipSterk/next-auth
that referenced
this pull request
Aug 27, 2024
* fix(ts): reudce public type surface * change * fix * simplify * simplify * simplify * chore: update links in index.ts * mark `isClientError` as internal --------- Co-authored-by: Nico Domino <yo@ndo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been re-exporting some types in multiple places, which is confusing, and also exported some internal types.