Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(d1): refactor to cleanup adapter src #10904

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented May 14, 2024

☕️ Reasoning

  • Extract all manual sql queries to a separate queries.ts file
  • Minor cleanup like removing extra JSDoc when theres already a TS Type annotation

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 10:12am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 10:12am
proxy ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 10:12am

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters d1 labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.48%. Comparing base (e2eacc2) to head (81df8e0).

❗ Current head 81df8e0 differs from pull request most recent head c93594c. Consider uploading reports for the commit c93594c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10904      +/-   ##
==========================================
- Coverage   38.35%   37.48%   -0.87%     
==========================================
  Files         175      173       -2     
  Lines       27437    27012     -425     
  Branches     1206     1163      -43     
==========================================
- Hits        10524    10126     -398     
+ Misses      16913    16886      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 requested a review from ubbe-xyz as a code owner May 14, 2024 10:05
@ndom91 ndom91 merged commit 5538080 into main May 14, 2024
9 of 10 checks passed
@ndom91 ndom91 deleted the ndom91/cleanup-d1-adapter branch May 14, 2024 10:06
hillac pushed a commit to hillac/next-auth that referenced this pull request Jun 19, 2024
k3k8 pushed a commit to k3k8/next-auth that referenced this pull request Aug 1, 2024
JipSterk pushed a commit to JipSterk/next-auth that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters d1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant