Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sveltekit): remove trailing slash in webAuthn baseUrl #10953

Merged
merged 2 commits into from
May 19, 2024

Conversation

sillvva
Copy link
Contributor

@sillvva sillvva commented May 18, 2024

☕️ Reasoning

Fixes a 404 by removing an extra / in the URL

const baseUrl = `${base}/auth/`

`${baseUrl}/webauthn-options/${providerId}?${params}`

Request URL: http://localhost:5173/auth//webauthn-options/webauthn?action=register
Request Method: GET
Status Code: 404 Not Found (from service worker)

The Fix

- const baseUrl = `${base}/auth/`
+ const baseUrl = `${base}/auth`

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #10947

📌 Resources

@sillvva sillvva requested a review from ThangHuuVu as a code owner May 18, 2024 13:06
Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) May 19, 2024 10:32am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 19, 2024 10:32am

Copy link

vercel bot commented May 18, 2024

@sillvva is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Thanks 🙏

@ndom91 ndom91 changed the title fix(sveltekit): remove extra / in URL. Fixes 404 fix(sveltekit): remove trailing slash in webAuthn baseUrl May 19, 2024
@ndom91 ndom91 merged commit 2a5b13d into nextauthjs:main May 19, 2024
7 of 9 checks passed
hillac pushed a commit to hillac/next-auth that referenced this pull request Jun 19, 2024
k3k8 pushed a commit to k3k8/next-auth that referenced this pull request Aug 1, 2024
JipSterk pushed a commit to JipSterk/next-auth that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in webAuthnOptions
2 participants