-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sveltekit): remove trailing slash in webAuthn baseUrl
#10953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@sillvva is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ndom91
approved these changes
May 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Thanks 🙏
ndom91
changed the title
fix(sveltekit): remove extra / in URL. Fixes 404
fix(sveltekit): remove trailing slash in webAuthn May 19, 2024
baseUrl
hillac
pushed a commit
to hillac/next-auth
that referenced
this pull request
Jun 19, 2024
k3k8
pushed a commit
to k3k8/next-auth
that referenced
this pull request
Aug 1, 2024
JipSterk
pushed a commit
to JipSterk/next-auth
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Fixes a 404 by removing an extra
/
in the URLnext-auth/packages/frameworks-sveltekit/src/lib/webauthn.ts
Line 21 in d53d47c
next-auth/packages/frameworks-sveltekit/src/lib/webauthn.ts
Line 27 in d53d47c
The Fix
🧢 Checklist
🎫 Affected issues
Fixes: #10947
📌 Resources