-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refetch session even if there is no current session #11075
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@OrJDev is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Bumping this |
@balazsorban44 really need this one its just 1 line of changes |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11075 +/- ##
=======================================
Coverage 40.08% 40.08%
=======================================
Files 179 179
Lines 28739 28739
Branches 1254 1260 +6
=======================================
Hits 11519 11519
Misses 17220 17220 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @OrJDev , I looked at the code change - I'm not 100% sure why the logic is here in the first place. IMO, it is OK to get this in, but if there's any regression I am afraid that we'll have to revert.
Awesome thank you |
☕️ Reasoning
I have an app that automatically sign in on the server side after signing up with credentials, trying to refetch the session (after calling the server function) without hard refreshing the page seems to be impossible, that is because no functions update the session directly except for
update
, however this function is only a thing when the session is already fetched and exists on the client side, that makes it so there is no possible way to refetch the session at any time i want it to.In this example session is an object and r is not defined
🧢 Checklist
🎫 Affected issues
📌 Resources