Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): add threads #11215

Conversation

c7e715d1b04b17683718fb1e8944cc28
Copy link
Contributor

☕️ Reasoning

Now that the threads.net API is out, I'll add it to the provider.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 4:48pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 4:48pm

Copy link

vercel bot commented Jun 20, 2024

@c7e715d1b04b17683718fb1e8944cc28 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added providers core Refers to `@auth/core` labels Jun 20, 2024
@ndom91 ndom91 changed the title Feat(providers): Add threads.net feat(providers): add threads Jun 20, 2024
@ndom91
Copy link
Member

ndom91 commented Jun 20, 2024

Nice, thanks!

A docs page under /docs/pages/getting-started/providers/threads.mdx would be great 🙏 just check out any of the other existing ones for an example

@c7e715d1b04b17683718fb1e8944cc28
Copy link
Contributor Author

Okay! Add now

@ThangHuuVu
Copy link
Member

ThangHuuVu commented Jun 20, 2024

@ndom91 could you help to setup a Threads OAuth app? 👀

@ndom91
Copy link
Member

ndom91 commented Jun 20, 2024

@ThangHuuVu ahh this runs over the meta / facebook developer portal it looks like, right?

I wasn't able to create a Facebook nor Instagram developer app without "verifying my identity" with them by uploading a copy of my passport or other ID, which I definitely did not want Meta having 😂

@ThangHuuVu
Copy link
Member

Haha ok no problem, I think we can merge this and I will set it up later 👍

Copy link
Contributor

@k-taro56 k-taro56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run pnpm format

@k-taro56
Copy link
Contributor

I'm sorry, I did Add single comment by mistake.
I should have done Start a Review.

@ThangHuuVu
Copy link
Member

@k-taro56 no worries, I formatted the file per your suggestion.
@c7e715d1b04b17683718fb1e8944cc28 I leave the biography out of the requesting scope since its not necessary for next-auth, I see that you already written in the doc that it can be added if necessary so people can adjust if needed 👍

@c7e715d1b04b17683718fb1e8944cc28
Copy link
Contributor Author

@c7e715d1b04b17683718fb1e8944cc28 I leave the biography out of the requesting scope since its not necessary for next-auth, I see that you already written in the doc that it can be added if necessary so people can adjust if needed 👍

We certainly should not include unnecessary parameters in the request.
I forgot about that, thank you for handling it!

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 135 lines in your changes missing coverage. Please review.

Project coverage is 39.92%. Comparing base (bc4a251) to head (0739273).

Files Patch % Lines
packages/core/src/providers/threads.ts 0.00% 135 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11215      +/-   ##
==========================================
- Coverage   40.11%   39.92%   -0.19%     
==========================================
  Files         178      179       +1     
  Lines       28536    28671     +135     
  Branches     1242     1249       +7     
==========================================
  Hits        11446    11446              
- Misses      17090    17225     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThangHuuVu ThangHuuVu merged commit 4e9d2a2 into nextauthjs:main Jun 21, 2024
11 of 15 checks passed

<img align="right" src="/img/providers/threads.svg" height="64" width="64" />

# Instagram Provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this headline correct or should it have been "Threads Provider"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. I agree with your suggestion.
I have created a new PR.
#11245

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding so quickly!

@k-taro56 k-taro56 mentioned this pull request Jun 24, 2024
3 tasks
k3k8 pushed a commit to k3k8/next-auth that referenced this pull request Aug 1, 2024
* Feature: Threads Provider

* Feature: Logo and ISSUE_TEMPLATE

* Feature: MDX in Getting Started Page

* formatting & update doc

* Update threads.ts

---------

Co-authored-by: Thang Vu <hi@thvu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants