Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit names for Entities names to workaround minify #9129

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

gkorland
Copy link
Contributor

ref #9007

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

NextJS build process can shorten the classes names, it's safer to use the entities classname explicitly in the code to avoid this issue

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #8777

📌 Resources

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 10:03pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2023 10:03pm

Copy link

vercel bot commented Nov 12, 2023

@gkorland is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters typeorm @auth/typeorm-adapter labels Nov 12, 2023
@gkorland
Copy link
Contributor Author

@balazsorban44 FYI - What do you think about this solution?

@balazsorban44 balazsorban44 merged commit 465e882 into nextauthjs:main Nov 13, 2023
11 of 13 checks passed
@gkorland
Copy link
Contributor Author

@balazsorban44 thanks, that was quick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters typeorm @auth/typeorm-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://next-auth.js.org/errors#oauth_callback_handler_error No metadata for "AccountEntity"
2 participants