-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge @nextcloud/vue-richtext
into @nextcloud/vue
#3841
Conversation
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
d93daf2
to
9d82207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that was fast! Thank you very much. ❤️
I tried it with the latest spreed master. The link picker in NcRichContenteditable
works like a charm.
We need to expose the searchProvider
function (in src/components/NcRichText/NcReferencePicker/providerHelper.js
) because it is used in Text (which has its own implementation using Tribute).
It is exposed in src/components/NcRichText/index.js
.
I'll make some more tests with Text soon.
This comment was marked as resolved.
This comment was marked as resolved.
Ok, test results are all green: Spreed
Text
All good from my pov. ✔️ ❤️ I'll prepare the PRs to bring this in spreed and text to the next Vue lib release. |
This comment was marked as resolved.
This comment was marked as resolved.
Great to hear! Thanks a lot for checking. |
@nextcloud/vue-richtext
into @nextcloud/vue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested in spreed and text
- link picker stuff ✔️
- reference widget stuff ✔️
- NcRichText ✔️
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Let me also add the |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me 👌
I didn't test myself, but apparently @julien-nc did so
Great to get @nextcloud/vue-richtext
incorporated into @nextcloud/vue
Tested now as well with Text and works like a charm 🎉 |
This PR merges @nextcloud/vue-richtext into the repository here. I mainly copied the code from
vue-richtext
, adjusted the import paths, fixed lint errors and removed the dependency tovue-richtext
.The
NcRichText
example in the docs seems to work fine: https://deploy-preview-3841--nextcloud-vue-components.netlify.app/#/Components/NcRichText?id=ncrichtext-1But a deeper check is still necessary, since I don't know the internal of
vue-richtext
and which exports are necessary. We also need to figure out how to handle therichtext.scss
file.Anyway, it would be best if you could check whether
@nextcloud/vue
more or less works as a drop-in-replacement for@nextcloud/vue-richtext
now.I still have to fix the jsdoc lint warnings, though.
Closes #3812.