Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable7] NcAppSidebarTabs: fix rendering tabs with CSS icon in OCA.Files.Sidebar #4112

Merged
merged 1 commit into from
May 15, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 13, 2023

Partial backport of #4111

Second problem is not relevant to stable7 and cannot be backported.

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels May 13, 2023
@ShGKme ShGKme added this to the 7.11.5 milestone May 13, 2023
@ShGKme ShGKme self-assigned this May 13, 2023
@ShGKme ShGKme marked this pull request as draft May 13, 2023 22:29
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the backport/render-tab-in-tabs-without-context branch from 520287e to 7d6a4b3 Compare May 13, 2023 22:36
@ShGKme
Copy link
Contributor Author

ShGKme commented May 13, 2023

Tested on server/stable26 with activity/stable26 on the Files sidebar.

image

Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the activity app on stable26

@nickvergessen nickvergessen merged commit 7a38bd8 into stable7 May 15, 2023
@nickvergessen nickvergessen deleted the backport/render-tab-in-tabs-without-context branch May 15, 2023 09:29
@nickvergessen nickvergessen changed the title NcAppSidebarTabs: fix rendering tabs with CSS icon in OCA.Files.Sidebar [stable7] NcAppSidebarTabs: fix rendering tabs with CSS icon in OCA.Files.Sidebar May 15, 2023
@nickvergessen nickvergessen mentioned this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants