-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcModal): fix focus-trap fallback #4266
Conversation
/backport to stable7 |
@skjnldsv something is wrong with the package lock: 20,786 additions, 2 deletions |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
4fef53a
to
648a4ba
Compare
Nice catch, haven't updated node on this terminal since the LTS merge |
Preview looks good, and content still focusable 👍 |
The backport to stable7 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable7
git pull origin stable7
# Create the new backport branch
git checkout -b fix/foo-stable7
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable7 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Fix #4265
Sometimes the content is empty or not ready yet.