Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(a11y): Use button as header menu trigger #4481

Merged
merged 1 commit into from
Sep 6, 2023
Merged

enh(a11y): Use button as header menu trigger #4481

merged 1 commit into from
Sep 6, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Aug 29, 2023 •
edited
Loading

@Pytal Pytal added the 2. developing Work in progress label Aug 29, 2023
@Pytal Pytal self-assigned this Aug 29, 2023
This was referenced Aug 29, 2023
Closed
Closed
@Pytal
enh(a11y): Use button as header menu trigger
63aca76 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal changed the title [WIP] enh(a11y): Accessible header menu enh(a11y): Use button as header menu trigger Aug 30, 2023
@Pytal Pytal marked this pull request as ready for review August 30, 2023 23:05
@Pytal Pytal added 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities and removed 2. developing Work in progress labels Aug 30, 2023
@Pytal Pytal added this to the 8.0.0 milestone Aug 30, 2023
@Pytal Pytal added the enhancement New feature or request label Aug 30, 2023
skjnldsv
skjnldsv approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic make sense but haven't tested

@Pytal Pytal requested a review from artonge September 6, 2023 00:39
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 6, 2023
@Pytal Pytal merged commit 849f145 into master Sep 6, 2023
16 checks passed
@Pytal Pytal deleted the enh/a11y/header-menu branch September 6, 2023 17:11
@Pytal Pytal mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @artonge @skjnldsv