fix(NcSelect): make id truly uniqual #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
3. to review
10 tasks
susnux
approved these changes
Oct 4, 2023
JuliaKirschenheuter
approved these changes
Oct 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
VueSelect generates unique IDs for some elements. But it is just auto-increment id. For example,
#vs1-compobox.It works fine while only one copy of VueSelect (
@nextcloud/vue) is used. Otherwise, there are several VueSelects with their own uid sequence. Then there are many#vs1-compoboxelements on the page.This PR defines a default value for VueSelect.uid with a random string.
Now nc-selects have IDs like
#vs-wxtrv-compobox🖼️ Screenshots
Before
After
🚧 Tasks
🏁 Checklist