Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update opcache settings #199

Merged
merged 1 commit into from
Feb 9, 2022
Merged

update opcache settings #199

merged 1 commit into from
Feb 9, 2022

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Feb 9, 2022

Fix #192

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Feb 9, 2022
@szaimen szaimen added this to the next milestone Feb 9, 2022
@szaimen szaimen requested a review from MichaIng February 9, 2022 17:28
@szaimen
Copy link
Collaborator Author

szaimen commented Feb 9, 2022

@MichaIng does this look good to you or do wee need to keep setting opcache.interned_strings_buffer to a higher value than 8?

@MichaIng
Copy link
Member

MichaIng commented Feb 9, 2022

Generally looks fine, given that the other settings are PHP defaults anyway. Is there a way for users to pass overrides for PHP settings, i.e. that there is the possibility to increase interned strings buffer when needed? Else probably using 16 to mute the warning in more cases is reasonable. The interned strings buffer is allocated as part of the 128 MiB overall OPcache size, and given that Nextcloud is using only something between 32 and 64 MiB, there is not an issue with allocation some more for the interned strings buffer.

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 9, 2022

Thanks for your review and answer! Since there is currently no way to adjust this for the user, I'll use 16 as value for the opcache.interned_strings_buffer.

@szaimen szaimen force-pushed the enh/192/update-opcache-settings branch from 1f0392f to cea700e Compare February 9, 2022 17:36
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/192/update-opcache-settings branch from cea700e to 98cb4e9 Compare February 9, 2022 17:37
@juliusknorr
Copy link
Member

Makes sense, thanks also for the good insight on the issue @MichaIng

Should we maybe also adapt our default recommendations in the documentation then a bit?

@szaimen szaimen merged commit ad5e3c3 into main Feb 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/192/update-opcache-settings branch February 9, 2022 17:38
@szaimen
Copy link
Collaborator Author

szaimen commented Feb 9, 2022

Thanks for the review julius!

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 9, 2022

Should we maybe also adapt our default recommendations in the documentation then a bit?

I think it is already adjusted...

@MichaIng
Copy link
Member

MichaIng commented Feb 9, 2022

Since Apache2 is used as webserver, when mod_php (instead of PHP-FPM) is used, a custom config snippet with php_admin_value opcache.interned_strings_buffer "16" would be possible as well, when that is possible to pass to the container.

The docs are already adjusted, but we could add the hint that in some cases a higher than default interned strings buffer is required/recommended, in addition to what the admin panel shows. So admins are made aware of this in the first place, respectively can verify that the admin panel warning is not so unexpected when following the link shown on the admin panel as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjust opcache settings
3 participants