-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update opcache settings #199
Conversation
@MichaIng does this look good to you or do wee need to keep setting opcache.interned_strings_buffer to a higher value than 8? |
Generally looks fine, given that the other settings are PHP defaults anyway. Is there a way for users to pass overrides for PHP settings, i.e. that there is the possibility to increase interned strings buffer when needed? Else probably using |
Thanks for your review and answer! Since there is currently no way to adjust this for the user, I'll use 16 as value for the opcache.interned_strings_buffer. |
1f0392f
to
cea700e
Compare
Signed-off-by: szaimen <szaimen@e.mail.de>
cea700e
to
98cb4e9
Compare
Makes sense, thanks also for the good insight on the issue @MichaIng Should we maybe also adapt our default recommendations in the documentation then a bit? |
Thanks for the review julius! |
I think it is already adjusted... |
Since Apache2 is used as webserver, when mod_php (instead of PHP-FPM) is used, a custom config snippet with The docs are already adjusted, but we could add the hint that in some cases a higher than default interned strings buffer is required/recommended, in addition to what the admin panel shows. So admins are made aware of this in the first place, respectively can verify that the admin panel warning is not so unexpected when following the link shown on the admin panel as well. |
Fix #192
Signed-off-by: szaimen szaimen@e.mail.de