Disable Apache proxy buffering #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
added
3. to review
32 tasks
|
LGTM, thanks! |
szaimen
approved these changes
Mar 8, 2024
|
This is now released with v8.0.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling proxy buffering is necessary to use Server-sent events (SSE), which is what NextPush use.
Generally, proxy buffering can be used to reduce connection load on the backend server if you have clients with very poor connection. The proxy closes the connection to the server sooner and keep delivering data slowly to the client. The advantage is pretty limited without a load balancer (on the proxy).
Note that if a user has defined another reverse proxy in front, for example to add a load balancer, they will be able to add proxy buffering with an exception for certain paths if necessary there.
Another solution is to set flushpackets to auto with a very low flushwait, but in my opinion flushpackets=on is good enough.
Related issues and discussions:
https://codeberg.org/NextPush/nextpush-android/issues/4
https://codeberg.org/NextPush/uppush/issues/8 (probably)
UP-NextPush/android#58
#4295
#4303