Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Cover Missing GPS and Photo Size #1349

Merged
merged 8 commits into from
Mar 25, 2024

Conversation

alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Feb 9, 2024

Backend not always returning array of some element (ArrayList<*>) with new xml props(EXTENDED_PROPERTY_METADATA_PHOTOS_SIZE, EXTENDED_PROPERTY_METADATA_PHOTOS_GPS) therefore client side have cast error.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Feb 9, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the bugfix/cover-missing-gps-and-photo-size branch from 81bb9bc to 79e3e46 Compare February 12, 2024 09:07
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@AndyScherzinger AndyScherzinger force-pushed the bugfix/cover-missing-gps-and-photo-size branch from 79e3e46 to dbc3882 Compare February 12, 2024 22:03
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the bugfix/cover-missing-gps-and-photo-size branch from dbc3882 to db43b0f Compare February 13, 2024 08:55
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@joshtrichards joshtrichards force-pushed the bugfix/cover-missing-gps-and-photo-size branch from db43b0f to 9a00794 Compare February 15, 2024 15:40
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the bugfix/cover-missing-gps-and-photo-size branch from f337ad7 to b639b59 Compare February 26, 2024 10:28
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #1349 (a2e15dd) into master (e4b7de0) will decrease coverage by 0.20%.
The diff coverage is 14.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1349      +/-   ##
============================================
- Coverage     49.15%   48.96%   -0.20%     
+ Complexity      999      996       -3     
============================================
  Files           206      206              
  Lines          7834     7826       -8     
  Branches       1015     1019       +4     
============================================
- Hits           3851     3832      -19     
- Misses         3441     3445       +4     
- Partials        542      549       +7     
Files Coverage Δ
...owncloud/android/lib/common/network/WebdavEntry.kt 82.82% <14.28%> (-3.71%) ⬇️

@alperozturk96 alperozturk96 force-pushed the bugfix/cover-missing-gps-and-photo-size branch from b639b59 to fda2c3d Compare March 12, 2024 15:09
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the bugfix/cover-missing-gps-and-photo-size branch from fda2c3d to c5969e6 Compare March 14, 2024 08:23
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the bugfix/cover-missing-gps-and-photo-size branch from c5969e6 to ed16035 Compare March 15, 2024 08:19
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 force-pushed the bugfix/cover-missing-gps-and-photo-size branch from ed16035 to 4c64325 Compare March 18, 2024 08:17
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/cover-missing-gps-and-photo-size branch from 6625a35 to 3b1f901 Compare March 21, 2024 08:29
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky tobiasKaminsky merged commit 52f0a97 into master Mar 25, 2024
19 of 21 checks passed
@tobiasKaminsky
Copy link
Member

/backport to stable-2.18

@tobiasKaminsky tobiasKaminsky deleted the bugfix/cover-missing-gps-and-photo-size branch March 25, 2024 07:58
Copy link

backportbot bot commented Mar 25, 2024

The backport to stable-2.18 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-2.18
git pull origin stable-2.18

# Create the new backport branch
git checkout -b backport/1349/stable-2.18

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b2794f50 4fa1e18e c3118d12 241b7fe5 87a2fb69 d21a1f69 3b1f9018 a2e15dda

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1349/stable-2.18

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/1349/stable-2.18."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants