Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Delete Cached Nextcloud Client For Account Removal #1387

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

alperozturk96
Copy link
Contributor

Not deleting cached Nextcloud client was causing authentication problem. Details

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link
Contributor

github-actions bot commented Mar 6, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 changed the title Bugfix Cached Nextcloud Client Deletion Bugfix Delete Cached Nextcloud Client For Account Removal Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #1387 (a3f7e63) into master (e9f238d) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1387      +/-   ##
============================================
+ Coverage     49.40%   49.43%   +0.03%     
- Complexity      999     1001       +2     
============================================
  Files           206      206              
  Lines          7805     7806       +1     
  Branches        998      998              
============================================
+ Hits           3856     3859       +3     
  Misses         3423     3423              
+ Partials        526      524       -2     
Files Coverage Δ
...loud/android/lib/common/OwnCloudClientManager.java 4.25% <0.00%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

@alperozturk96 alperozturk96 merged commit 9795692 into master Mar 7, 2024
22 of 23 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/nextcloud-client-delete branch March 7, 2024 08:02
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.19.0 milestone Mar 7, 2024
@tobiasKaminsky
Copy link
Member

/backport to stable-2.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication Problem After Locally Delete Account And Login Again With Same Account
4 participants