Use Work Manager For File Download #12308

alperozturk96 · 2023-12-20T11:47:23Z

Tests written, or not not needed

alperozturk96 · 2023-12-21T13:17:12Z

/rebase

alperozturk96 · 2023-12-21T14:02:32Z

/rebase

alperozturk96 · 2023-12-22T09:51:24Z

/rebase

alperozturk96 · 2023-12-26T14:13:15Z

Only one test is failing - "download_progress_is_updated[android(AVD) - 8.1.0] FAILED - java.lang.AssertionError: expected:<6> but was:<2>"

app/src/main/java/com/nextcloud/client/di/AppComponent.java

JonasMayerDev

Synchronizing Folders only downloads one file of the folder not all as expected

app/src/main/java/com/nextcloud/client/notifications/download/DownloadNotificationManager.kt

alperozturk96 · 2023-12-27T14:49:00Z

@JonasMayerDev Fix Sync

down_i.mp4

JonasMayerDev

New implemented function "isDownloading" does not the same thing as old one. Maybe reimplement it and make sure it does the same thing. Be careful when changing the functionality of a function to make sure everywhere it is used it is still fitting...

app/src/main/java/com/nextcloud/client/jobs/BackgroundJobManagerImpl.kt

app/src/main/java/com/owncloud/android/files/FileMenuFilter.java

app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java

app/src/main/java/com/owncloud/android/ui/adapter/OCFileListDelegate.kt

JonasMayerDev · 2023-12-28T11:59:26Z

Maybe it is a better idea to not change the download functionality and switch to chained worker in another pull request to make sure we don't introduce issues with new untested logic...? @alperozturk96

alperozturk96 · 2023-12-28T14:23:06Z

Maybe it is a better idea to not change the download functionality and switch to chained worker in another pull request to make sure we don't introduce issues with new untested logic...? @alperozturk96

getRequestDownloads() was causing the problem. I fixed it but for future implementation chained worker can be used as well.

alperozturk96 · 2023-12-28T14:24:43Z

New implemented function "isDownloading" does not the same thing as old one. Maybe reimplement it and make sure it does the same thing. Be careful when changing the functionality of a function to make sure everywhere it is used it is still fitting...

New function added into BackgroundJobManagerImpl that checks status of the current file. You can test it.

alperozturk96 · 2023-12-28T14:50:03Z

@JonasMayerDev Sync icon same as master, fyi.

Master

master_c.mp4

PR

pr_c.mp4

JonasMayerDev

Screen_recording_20231228_170425.webm

Download of folder happens in parallel, which messes with the progress notification.
Blue sync icon for a folder is only visible for first download
Sync of a folder can not be stopped

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>

Signed-off-by: alperozturk <alper_ozturk@proton.me>

github-actions · 2024-01-12T08:03:29Z

Codacy

Lint

Type	master	PR
Warnings	69	69
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	69	70
Dodgy code	353	351
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	6
Performance	54	54
Security	18	18
Total	542	538

github-actions · 2024-01-12T08:10:23Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12308.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

alperozturk96 added the 2. developing label Dec 20, 2023

alperozturk96 changed the title ~~Use Work Manager File Download~~ Use Work Manager For File Download Dec 20, 2023

alperozturk96 force-pushed the refactor/use-work-manager-file-download branch 2 times, most recently from d984c32 to df0be0a Compare December 21, 2023 12:36

alperozturk96 force-pushed the refactor/use-work-manager-file-download branch from 584ed8b to 28cffe1 Compare December 22, 2023 10:11

alperozturk96 added 3. to review and removed 2. developing labels Dec 22, 2023

alperozturk96 requested review from ZetaTom, JonasMayerDev and tobiasKaminsky December 22, 2023 11:51

alperozturk96 force-pushed the refactor/use-work-manager-file-download branch 3 times, most recently from a450370 to 041e836 Compare December 26, 2023 12:29

JonasMayerDev reviewed Dec 27, 2023

View reviewed changes

app/src/main/java/com/nextcloud/client/di/AppComponent.java Show resolved Hide resolved

alperozturk96 requested a review from JonasMayerDev December 27, 2023 11:11

JonasMayerDev requested changes Dec 27, 2023

View reviewed changes

app/src/main/java/com/nextcloud/client/notifications/download/DownloadNotificationManager.kt Outdated Show resolved Hide resolved

app/src/main/java/com/nextcloud/client/notifications/download/DownloadNotificationManager.kt Outdated Show resolved Hide resolved

alperozturk96 requested a review from JonasMayerDev December 27, 2023 14:49

JonasMayerDev requested changes Dec 28, 2023

View reviewed changes

alperozturk96 requested a review from JonasMayerDev December 28, 2023 14:50

JonasMayerDev requested changes Dec 28, 2023

View reviewed changes

alperozturk96 force-pushed the refactor/use-work-manager-file-download branch from dcba572 to 99fe9f3 Compare December 29, 2023 08:06

alperozturk96 and others added 24 commits January 12, 2024 08:51

No need for clear for each worker

d19b1d3

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Cancel action remove added

3e4cccf

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Cancel All notification when sync canncelled

b4e5416

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix cancel feature for individual file download inside folder

51bb589

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Use unique tag for all download type to fix sync problems

5ea707b

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix cancel for unique tag

1689aee

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Rename worker observer func

8ff2914

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Prevent unnecessary file download

f9d3305

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix cancel

7a0c591

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix cancel notification

5aa41ce

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix Cancel Notification Appearance and Progress Bar Visibility

17cdbc2

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Improve Notifications

85b68c2

Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>

Add long running task support

7970ba7

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Improve notifications for different custom Android OS

687c557

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Rebase master

98dd0c7

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Dont show success notifications

c4ba0e0

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Cancel fix

15dedf8

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Prepare all files to cancel

eb0735e

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix recursive worker start for folder

3b2824e

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix cancel and isDownloading

2a0b754

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix kotlin spotless check

6fed74a

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix isDownloading for nested folders

ed24172

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Fix cancel in same root

3ba4721

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Better notifications

95e9be6

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 force-pushed the refactor/use-work-manager-file-download branch from edab3e3 to 95e9be6 Compare January 12, 2024 07:51

Remove unused parameter

909c730

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 merged commit ed88a47 into master Jan 12, 2024
20 checks passed

delete-merged-branch bot deleted the refactor/use-work-manager-file-download branch January 12, 2024 09:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Work Manager For File Download #12308

Use Work Manager For File Download #12308

alperozturk96 commented Dec 20, 2023 •

edited

Loading

alperozturk96 commented Dec 21, 2023

alperozturk96 commented Dec 21, 2023

alperozturk96 commented Dec 22, 2023

alperozturk96 commented Dec 26, 2023

JonasMayerDev left a comment

alperozturk96 commented Dec 27, 2023

JonasMayerDev left a comment

JonasMayerDev commented Dec 28, 2023

alperozturk96 commented Dec 28, 2023

alperozturk96 commented Dec 28, 2023

alperozturk96 commented Dec 28, 2023

JonasMayerDev left a comment

github-actions bot commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

Use Work Manager For File Download #12308

Use Work Manager For File Download #12308

Conversation

alperozturk96 commented Dec 20, 2023 • edited Loading

alperozturk96 commented Dec 21, 2023

alperozturk96 commented Dec 21, 2023

alperozturk96 commented Dec 22, 2023

alperozturk96 commented Dec 26, 2023

JonasMayerDev left a comment

Choose a reason for hiding this comment

alperozturk96 commented Dec 27, 2023

JonasMayerDev left a comment

Choose a reason for hiding this comment

JonasMayerDev commented Dec 28, 2023

alperozturk96 commented Dec 28, 2023

alperozturk96 commented Dec 28, 2023

alperozturk96 commented Dec 28, 2023

JonasMayerDev left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 12, 2024

Codacy

Lint

SpotBugs

github-actions bot commented Jan 12, 2024

alperozturk96 commented Dec 20, 2023 •

edited

Loading