Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login Flow V2 Fix Compatibility Problems With Some Browsers #13025

Merged
merged 4 commits into from
May 21, 2024
Merged

Login Flow V2 Fix Compatibility Problems With Some Browsers #13025

merged 4 commits into from
May 21, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented May 21, 2024 •
edited
Loading

  • Tests written, or not not needed

What this PR Does?

  1. Removed Discouraged APIs usage scheduleAtFixedRate. Instead use scheduleWithFixedDelay.
  2. Fix compatibility issue with some browsers such as Via Browser
  3. Always launch default browser in new window.

How to Test Login Flow

  1. Install Via Browser
  2. Set Via Browser as default browser
  3. Try to complete login you shouldn't come across with any problem and complete whole login process.
  4. Repeat with different browsers such as Opera, Edge, Mozilla, Chrome etc

How to Test Login Flow and Cancel Button

  1. Delete app, reinstall the app
  2. Cancel login process
  3. Retry login process
  4. Repeat with different browsers such as Opera, Edge, Mozilla, Chrome etc

@alperozturk96
Fix compatibility problems with some browsers
2082b62 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/login-flow-v2-compatibility-issues-with-some-browsers branch from 3508780 to 2082b62 Compare May 21, 2024 09:53
Analysis: update lint results to reflect reduced error/warning count
475ecf6 
Signed-off-by: github-actions <github-actions@github.com>
@alperozturk96
Copy link
Collaborator Author

/rebase

@alperozturk96
Update lint results
ba4bfe5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Merge remote-tracking branch 'origin/bugfix/login-flow-v2-compatibili…
595b47f 
…ty-issues-with-some-browsers' into bugfix/login-flow-v2-compatibility-issues-with-some-browsers
alperozturk96
alperozturk96 commented May 21, 2024
View reviewed changes
scripts/analysis/lint-results.txt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our tests didn't trigger, I manually updated. Rebase didn't worked as well.

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13025.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7271
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code347347
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total572572

@alperozturk96 alperozturk96 merged commit 3be52a1 into master May 21, 2024
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/login-flow-v2-compatibility-issues-with-some-browsers branch May 21, 2024 17:20
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone May 21, 2024
@AndyScherzinger
Copy link
Member

/backport to stable-3.29

@backportbot backportbot bot mentioned this pull request May 21, 2024
Closed
2 tasks
@alperozturk96 alperozturk96 mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @AndyScherzinger