Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Open Calendar Events and Contacts #13149

Merged
merged 25 commits into from
Jul 30, 2024
Merged

Feature Open Calendar Events and Contacts #13149

merged 25 commits into from
Jul 30, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 19, 2024 •
edited
Loading

Needs nextcloud/server#46464

  • Tests written, or not not needed

How to Test?

  1. Install DAVx⁵ and sync via Nextcloud account
  2. Search calendar event or contact and give permission to read calendar event and contact, then press event app should redirect to internal app instead of web app.

How to Test?

  1. Don't give permission then try to open calendar event or contact, app should redirect to the web app.

Demo

ff.mp4

Duplicated Contacts

duplicated_contacts.mp4

@alperozturk96 alperozturk96 marked this pull request as draft June 19, 2024 07:58
@alperozturk96 alperozturk96 marked this pull request as ready for review June 19, 2024 07:59
@alperozturk96 alperozturk96 marked this pull request as draft June 19, 2024 07:59
@alperozturk96 alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch 3 times, most recently from 4d0a851 to 90dd165 Compare June 24, 2024 10:42
@tobiasKaminsky tobiasKaminsky linked an issue Jul 3, 2024 that may be closed by this pull request
Open calendar/contact directly from unified search #12679
Closed
@alperozturk96 alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch 2 times, most recently from 5e13b7a to 970fe26 Compare July 12, 2024 13:26
@alperozturk96 alperozturk96 marked this pull request as ready for review July 12, 2024 13:26
@alperozturk96 alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch 3 times, most recently from 9e88fb7 to b452eb4 Compare July 18, 2024 10:29
AndyScherzinger
AndyScherzinger approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jul 25, 2024
@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Can we merge this?

@alperozturk96 alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch from f45ad19 to 433ee4d Compare July 26, 2024 08:58
@alperozturk96
Test
7d9c88b 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add event managers for unified search
6f62d39 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add parseDateTimeRange
f07ef57 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Split subline
485a859 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
solve git conflicts
bc89338 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix dateformat
274132a 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
b3ab911 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Show toast message for fallback scenario
e036ec6 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add permission checks
2d1a06b 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Use displayName
69b4770 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add permission checks for calendar event
042583c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Use createdAt
d596d2f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Refactor
11a27eb 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Permission check on create
b66aeab 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
99f8390 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
2043abf 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Use feature only v30 and above
8b2f281 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Give user to the better feedback
4bddc4f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add getPhoneNumberById and getEmailById
6e91559 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
62c2c6f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Refactor
10550b5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Cover edge case for empty email and phone number for multiple contact…
97c6c95 
… that have same display_name

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add fallback icon for events, make SearchResultEntry extensions private
033c073 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the feature/add-calendar-events-and-contacts branch from 433ee4d to 033c073 Compare July 29, 2024 12:19
@alperozturk96
Remove extension for version check
730af29 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
2775f1c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13149.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings6262
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6363
Dodgy code306306
Experimental11
Internationalization77
Multithreaded correctness66
Performance5252
Security1818
Total516516

@alperozturk96 alperozturk96 merged commit 62df824 into master Jul 30, 2024
22 checks passed
@AndyScherzinger AndyScherzinger deleted the feature/add-calendar-events-and-contacts branch July 30, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.30.0
Development

Successfully merging this pull request may close these issues.

Open calendar/contact directly from unified search
3 participants
@alperozturk96 @AndyScherzinger @tobiasKaminsky