Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ss tests #13192

Merged
merged 25 commits into from
Aug 8, 2024
Merged

Fix ss tests #13192

merged 25 commits into from
Aug 8, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 27, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 force-pushed the fix-ss-tests branch 4 times, most recently from 3c5bd42 to c4b61f2 Compare July 4, 2024 08:56
@alperozturk96 alperozturk96 force-pushed the fix-ss-tests branch 3 times, most recently from a75bec1 to e935df8 Compare July 8, 2024 06:50
@alperozturk96 alperozturk96 force-pushed the fix-ss-tests branch 2 times, most recently from 3315267 to 25dced4 Compare August 6, 2024 08:04
@alperozturk96 alperozturk96 marked this pull request as draft August 6, 2024 12:43
@alperozturk96
Fix git conflicts
80c46b8 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
try with thread sleep
c8bf86c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove sleeps
f73c8db 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
test with api level 34
ebfdf65 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
check
e386f87 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
check
6550778 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
try with 30
1e6c72d 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
add new permission for android 11
9c4c417 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
test with api level 29
9cd1c7a 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
test with api level 29
f9cc2e1 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
catch exception
3800cd5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Try with IntentsTestRule
34961f2 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use launchActivity
edef8f1 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use screenshotViaName
9929f30 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
test hardcoded names
a2a6d33 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use test class name for fix unknown class name
f4c92e7 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix java.lang.IndexOutOfBoundsException: getChars (-1 ... 0) starts b…
7506811 
…efore 0 for login test

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Update ss
de27991 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add onCompleted for loading
12d105b 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
use idling resources
612eece 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
1859aad 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix code analytics
e713bef 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Use correct thread and fix idling logic
1ba24ce 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Use increment and decrement inside test not in production code
d843794 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Use EspressoIdlingResource for only tests
a9203f9 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Codacy

Lint

TypemasterPR
Warnings6262
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code305305
Experimental11
Internationalization77
Multithreaded correctness66
Performance5252
Security1818
Total516516

@alperozturk96 alperozturk96 marked this pull request as ready for review August 8, 2024 08:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13192.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit ffbff3f into master Aug 8, 2024
23 checks passed
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.29

@backportbot backportbot bot mentioned this pull request Aug 8, 2024
Merged
2 tasks
@alperozturk96 alperozturk96 mentioned this pull request Sep 11, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @tobiasKaminsky