Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Share Link Dialog to Kotlin #13229

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jul 4, 2024

  • Tests written, or not not needed

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

github-actions bot commented Jul 4, 2024

Codacy

Lint

TypemasterPR
Warnings6363
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6565
Dodgy code314309
Experimental11
Internationalization77
Multithreaded correctness66
Performance5352
Security1818
Total528522

Copy link

github-actions bot commented Jul 4, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13229.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 12e4ffa into master Jul 4, 2024
22 checks passed
@AndyScherzinger AndyScherzinger deleted the convert-share-link-dialog-to-kt branch July 4, 2024 19:47
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants