Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug-Fix Reach Result After Operation Failed For Widget #13230

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Bug-Fix Reach Result After Operation Failed For Widget #13230

merged 1 commit into from
Jul 5, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jul 4, 2024 •
edited
Loading

  • Tests written, or not not needed

Problem

  • Before checking isSuccess set the adapter

What does This PR

  • Checks isSuccess then set the adapter
  • Simplifies coroutinescope block logic

How to Test?

  • Try to add widget

@alperozturk96
Fix
96753ab 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 linked an issue Jul 4, 2024 that may be closed by this pull request
Trying to place a widget causes an error #13228
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Codacy

Lint

TypemasterPR
Warnings6363
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6565
Dodgy code314314
Experimental11
Internationalization77
Multithreaded correctness66
Performance5353
Security1818
Total528528

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13230.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 139b6e4 into master Jul 5, 2024
22 checks passed
@AndyScherzinger AndyScherzinger deleted the bugfix/reach-data-after-operation-failed-for-widget branch July 5, 2024 07:58
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jul 5, 2024
@joshtrichards joshtrichards mentioned this pull request Jul 5, 2024
Closed
4 tasks
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.29

@backportbot backportbot bot mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.30.0
Development

Successfully merging this pull request may close these issues.

Trying to place a widget causes an error
2 participants
@alperozturk96 @AndyScherzinger