Fix - Edit, Delete Behaviors on PreviewImageActivity

[alperozturk96]

• Tests written, or not not needed

Problems?

1. The first time an image is selected for editing, the app flickers for a brief moment and the user have to press the same button again.
2. Does not focus on the next image after deleting from the image detail page.
3. If last image deleted from image detail page, previous screen is not updated, still last image is visible after deletion.

Steps to Reproduce 1

1. Open the application
2. Go to Media view
3. Select an image that has never been edited
4. Tap on the three dot menu and tap the edit button

Steps to Reproduce 2

1. Open the application
2. Go to Media view
3. Have multiple images
4. Select an image that and delete

Steps to Reproduce 3

1. Open the application
2. Go to Media view
3. Have one image in media screen
4. Select the last image and delete

Fixes

1. When the user presses the edit button, if the image is not yet downloaded, show a loading dialog. Wait for the download to complete, then start the edit image activity.
2. After deletion update view pager
3. After last image deletion send refresh search event broadcast

Demo

fix.mp4

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13340.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	62	62
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	63	63
Correctness	63	63
Dodgy code	306	306
Experimental	1	1
Internationalization	7	7
Multithreaded correctness	6	6
Performance	52	52
Security	18	18
Total	516	516

[alperozturk96]

/backport to stable-3.29

[backportbot]

The backport to stable-3.29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.29
git pull origin stable-3.29

# Create the new backport branch
git checkout -b backport/13340/stable-3.29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7eac3e66 7dfc56c7 60571635 f5011c31 8a42462c ed7d0aaa

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/13340/stable-3.29

Error: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.