Fix opening files #1651
Fix opening files #1651
Conversation
|
Is it available in beta? |
|
No, but it works. :P Hopefully we'll have it in 2.0. |
|
I don't see it on my mobile. I'm not at a Computer... Do you have a way to do or a working apk? |
|
👍 test on my Android 7.1.1 device is fine, can't say anything about older Android versions. |
|
I can report several devices, but I'm unable to code ... If someone can integrate this in the rc-version from store or delivering an apk, I will check. Thanks to all - extreme good work!!!!!! |
|
@mario as for 2.0.0 I'd prefer if we just release 2.0.0 and put this into a 2.0.1 via a bugfix branch 2.0.x to not having to do another RC and not postpone 2.0.0 (due to golden master). Just my opinion though! |
|
Sure
…On Wed, 11 Oct 2017 at 11:57, Andy Scherzinger ***@***.***> wrote:
@mario <https://github.com/mario> as for 2.0.0 I'd prefer if we just
release 2.0.0 and put this into a 2.0.1 via a bugfix branch 2.0.x to not
having to do another RC and not postpone 2.0.0 (due to golden master). Just
my opinion though!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1651 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWsnEjm6lqT5xgnNhD2Aanf5hDmhWTks5srJEkgaJpZM4P0Oc0>
.
|
|
Yes, same opinion as Andy. |
|
2.1 needs to have all we agreed on, so against it for October.
But super fast 2.0.1 is fine since I need those two fixes, especially since one is for a customer.
|
|
Well, for 2.1 I'd also be fine with just Hacktober + open PRs |
|
I'd also be fine with having two releases within 2 month or so, like putting the rest into 2.2 but getting back to a release schedule of 4-6 weeks for bugfix/feature releases maybe 2 month tops sometimes. |
|
KO, whatever you two decide, but I need this FAST. Same with other PR I'm gonna open. |
|
I don't want to hurry. But I would also be very thankful if someone can provide me a apk-file for testing. I can check it on several Android-Systems-/Devices and will report results. Thanks, Team |
|
@kangaroo72 it's gonna be in the next daily build on f-droid. |
|
@mario cool - I'll check - thank you!!!! |
|
@mario - Wenn the next daily build on f-droid arrives, is it the "nextcloud-dev" app? |
|
Yes.
…On Fri, Oct 13, 2017 at 8:26 PM, kangaroo72 ***@***.***> wrote:
@mario <https://github.com/mario> - Wenn the next daily build on f-droid
arrives, is it the "nextcloud-dev" app?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1651 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWsjh2MFaZtiJG3Zlc0Hb3uQBRLO9-ks5sr6tlgaJpZM4P0Oc0>
.
|
|
@kangaroo72 news? :) |
|
eeeh - not yet? F-Droid shows Version 20170930 ... |
|
Well, we won't have 2.0.1 unless something major happens - 2.1 is the next release! :) |
|
(but F-droid Dev should have built it, but I'm no F-droid expert) |
|
Isn't it possible to submit your apk? |
|
No, f-droid builds the app from source themselves... |
AndyScherzinger
force-pushed
the
fix-word-opening
branch
from
1027e09
to
9e0d091
Compare
AndyScherzinger
force-pushed
the
fix-word-opening
branch
2 times, most recently
from
7810aec
to
c738f9b
Compare
AndyScherzinger
force-pushed
the
fix-word-opening
branch
from
c738f9b
to
dfec34d
Compare
|
pinging @tobiasKaminsky for review, see tested successfully on my OPT3 - #1651 (comment) |
|
👍 I'll rebase and merge once #1559 is done. |
Signed-off-by: Mario Danic <mario@lovelyhq.com>
Signed-off-by: Mario Danic <mario@lovelyhq.com>
tobiasKaminsky
force-pushed
the
fix-word-opening
branch
from
dfec34d
to
4d49735
Compare
|
Downloaded the latest developer Version apk file today, issue is still there. Can you please advise where to download an apk that includes this fix ? Thank you ! |
|
This will be available as soon as #1775 is merged and run. |
Some apps are stupid and won't allow us to open files in write mode. This fixes it.
I think this is important for 2.0, but you decide...
resolves #751
Signed-off-by: Mario Danic mario@lovelyhq.com