Skip to content

Commit a138393

Browse files
committed
Improve design of hour input
Signed-off-by: Louis Chemineau <louis@chmn.me>
1 parent 940f193 commit a138393

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

js/backup-adminSettings.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/backup-adminSettings.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/GeneralSettingsSection.vue

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,15 @@
3737
:disabled="loadingFetchSettings"
3838
name="timeSlotsStart"
3939
@change="setSettings">
40-
<option v-for="(hour, index) in new Array(24)" :key="index" :value="index">{{ index }}</option>
40+
<option v-for="(hour, index) in new Array(24)" :key="index" :value="index">{{ index | leadingZero }}:00</option>
4141
</select>
42-
{{ t('backup', 'h') }}
4342
{{ t('backup', 'and') }}
4443
<select v-model.number="settings.timeSlotsEnd"
4544
:disabled="loadingFetchSettings"
4645
name="timeSlotsEnd"
4746
@change="setSettings">
48-
<option v-for="(hour, index) in new Array(24)" :key="index" :value="index">{{ index }}</option>
47+
<option v-for="(hour, index) in new Array(24)" :key="index" :value="index">{{ index | leadingZero }}:00</option>
4948
</select>
50-
{{ t('backup', 'h') }}
5149
</label>
5250

5351
<CheckboxRadioSwitch
@@ -212,6 +210,18 @@ export default {
212210
Modal,
213211
},
214212
213+
filters: {
214+
/**
215+
* Add a leading '0' of the passed number is inferior to 10.
216+
*
217+
* @param {number} number - the number to prefix.
218+
* @return {string}
219+
*/
220+
leadingZero(number) {
221+
return (number < 10 ? '0' : '') + number
222+
},
223+
},
224+
215225
data() {
216226
return {
217227
// Init settings with dummy value to have the form displayed initial during loading.

0 commit comments

Comments
 (0)