Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n messages in html files aren't picked up by translation bot #456

Closed
marcelklehr opened this issue Mar 17, 2018 · 3 comments
Closed

l10n messages in html files aren't picked up by translation bot #456

marcelklehr opened this issue Mar 17, 2018 · 3 comments

Comments

@marcelklehr
Copy link
Member

marcelklehr commented Mar 17, 2018

Hey @MorrisJobke
Thanks for setting up the translation infrastructure for us. There appears to be one string that isn't picked up, however. (or simply hasn't been translated perhaps?)

<a class="button bookmarklet" href=""><%- t('bookmarks', 'Add to {instanceName} ', {instanceName: oc_defaults.name}) %></a>

Is there anything wrong on our end?

@MorrisJobke
Copy link
Member

We only scan php, js, jsx, ts and tsx files. Could you open a ticket in the docker-ci repo to also include html files in the parsing process? Thanks

@marcelklehr marcelklehr changed the title Parametrized l10n message isn't picked up by translation bot l10n messages in html files aren't picked up by translation bot Mar 22, 2018
@MorrisJobke
Copy link
Member

Should be fixed by tomorrows run of the transifex sync. ;)

@marcelklehr
Copy link
Member Author

🎉 Awesome! Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants