Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories of an event can't be updated #5785

Closed
st3iny opened this issue Feb 21, 2024 · 12 comments · Fixed by #5982
Closed

Categories of an event can't be updated #5785

st3iny opened this issue Feb 21, 2024 · 12 comments · Fixed by #5982
Labels
3. to review Waiting for reviews bug Feature: Categories Feature: Editor skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@st3iny
Copy link
Member

st3iny commented Feb 21, 2024

Steps to reproduce

  1. Edit and event.
  2. Open the sidebar editor.
  3. Add some categories.
  4. Save the event.

Expected behavior

It should save the event and all selected categories.

Actual behaviour

An error toast is shown, the event is not saved and the category picker is emptied.

2024-02-21.09-22-43.mp4

Calendar app version

main

Browser log

Uncaught (in promise) TypeError: aValue.replace is not a function
    at Object.toICAL (ical.js:430:1)
    at ICAL.stringify.stringify.value (ical.js:1698:1)
    at ICAL.stringify.stringify.multiValue (ical.js:1675:1)
    at ICAL.stringify.stringify.property (ical.js:1612:1)
    at ICAL.stringify.stringify.component (ical.js:1498:1)
    at ICAL.stringify.stringify.component (ical.js:1507:1)
    at Component.toString (ical.js:2772:1)
    at CalendarComponent.toICS (index.es.mjs:9161:1)
    at Store.updateCalendarObject (calendarObjects.js:226:1)
    at Array.wrappedActionHandler (vuex.esm.js:851:1)
@st3iny st3iny added 1. to develop Accepted and waiting to be taken care of bug Feature: Editor Feature: Categories skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Feb 21, 2024
@Gehilfe
Copy link

Gehilfe commented Apr 25, 2024

Same Problem here.

@phantom943
Copy link

We also have this problem. By bisecting the release history, we found out that this bug was introduced in v4.7.0 (as the last version where it works is 4.6.7)

@comsyspro
Copy link

same here. can you downgrade somehow to calendar v4.6.7 and if yes how to do it?

@phantom943
Copy link

@comsyspro yes you can
https://help.nextcloud.com/t/how-to-downgrade-calendar-app-from-3-0-3-to-3-0-2/129915/2
here are the instructions.
However, the "invite circle to event" feature was added in 4.7.0, so downgrading wouldn't be feasible for us.

@comsyspro
Copy link

i downgraded to v4.7.0 but v4.6.7 was not possible because this version is not compatible. so the only solution is to fix the code.

@b90g
Copy link

b90g commented May 2, 2024

Calendar 4.7.2 on NC 28.0.5 with php8.2.18 - having this issue.

@st3iny st3iny added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels May 3, 2024
@protegh
Copy link

protegh commented May 8, 2024

Adding a category from the pull down list works with version 4.7.3 but adding a new own category is still broken.

@comsyspro
Copy link

i just updated to the new calendar version 4.7.3 and i can't even create a normal entry so it seems that something failed with the new code.

please have a look:
image

image

@st3iny
Copy link
Member Author

st3iny commented May 10, 2024

@comsyspro It looks like your only calendar (Aufgaben) does not support VEVENTs because it was created through the Tasks app. Please create a new calendar and try again.

In general, please open a new issue next time and try not to revive old issues with unrelated bugs as you are generating a lot of notifications this way.

@comsyspro
Copy link

the error appeared after the upgrade with the events categories, so i suspected this was the problem. creating a new calendar did not resolve the issue and even deleting the new calendar failed. removing and reinstalling the calendar didn't help either. only a new installation of nextcloud was successful. there may be some fragments in the database that caused the problem.

@nmsw
Copy link

nmsw commented May 15, 2024

I have the exact same issue. The calendar was not created in the tasks app. A new regular calendar shows the same issue. Re-installing Nextcloud is not an option.

@miaulalala
Copy link
Contributor

@nmsw Please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Feature: Categories Feature: Editor skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants