show email for attendee

[tcitworld]

I would like to have some … at the end when they're truncated, but uib-typeahead doesn't seem to accept ternaries directly, so I guess we need a full filter just for this.

Fixes #45

[mention-bot]

@tcitworld, thanks for your PR! By analyzing the annotation information on this pull request, we identified @georgehrke, @raghunayyar and @jancborchardt to be potential reviewers

[coveralls]

Coverage remained the same at 29.07% when pulling 28be30d on show-email-attendee into c95f0eb on master.

[raghunayyar]

👍

[jancborchardt]

@tcitworld is it maybe possible to ellipsize just using CSS and going with the width? Normal ellipsizing is achieved using:

white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;

[tcitworld]

I'll try.

[tcitworld]

Still the same issue on mobile, but at least it's okay on desktop view.

[coveralls]

Coverage remained the same at 29.07% when pulling 26a7966 on show-email-attendee into c95f0eb on master.

[raghunayyar]

@nextcloud/designers anyone up for a review? :)

[raghunayyar]

@georgehrke please review, its long pending. :)

[jancborchardt]

@raghunayyar can you post a quick screenshot?

[tcitworld]

@jancborchardt
Desktop

Mobile

(Don't mind the display of the button, it's a Firefox Test Pilot issue)

[jancborchardt]

So as per the requirement in #45:

otherwise a user is not able to distinguish which email address is used.

it’s only shown when a name is duplicate, right? Because normally it’s not necessary to show it. :)

And yeah, it would be good to get the ellipsizing down, should be possible by restricting the width of the input. cc @nextcloud/designers anyone wants to help out here? :)

[georgehrke]

@tcitworld Can you please only display the email address when there are multiple email addresses available for a user :)

[ghost]

@georgehrke @tcitworld What about starting with the basic functionality as provided here and adding visual enhancements later on?

• showing email addresses only when contact has multiple email entries?
• maybe just showing the email domain part? (but that would collapse again in specific cases)
• select behavior via a setting switch in the calendar app?
  Etc.
  As most of my contact entries have multiple email addresses (work and home) it's very hard to figure out which is the correct name when setting up event invitations.
  So thanks @tcitworld as I was searching for that functionality, but my JS/PHP skills are to bad ;-)

[georgehrke]

maybe just showing the email domain part? (but that would collapse again in specific cases)

Then some emails will only have the domain and others will have the entire email address.
We should try to keep it consistent. Also I don't see a benefit in only showing the domain.

select behavior via a setting switch in the calendar app?

I'm sorry, but this won't happen. We are trying to make things simple. Showing the email address when multiple are available and hiding it when only one is available covers all usecases.
Adding a setting doesn't solve anything imho and only clutters the user interface. :)

[georgehrke]

Changed the behavior to the expected one:

please review @jancborchardt @tcitworld @eppfel

[tcitworld]

Oh, I thought I had pushed the change.
LGTM 👍

[skjnldsv]

Are you using the select2 function? This should have the same design as tags, admin//workflow or other selects on nextcloud :)

[georgehrke]

Not yet.
Is there proper documentation on select2 and presumably select1/select?

[skjnldsv]

I don't know! 😞
But systemtags is using it. https://select2.github.io