Fix datepicker alignment #1085
Merged
Fix datepicker alignment #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is master |
|
@skjnldsv nope |
I was confused! :D |
|
Travis going wild but it shouldn't matter. |
jancborchardt
requested changes
Feb 11, 2019
There was a problem hiding this comment.
- A regression: The radio buttons "Day/Week/Month" should stay connected instead of being 3 separate buttons.
- Another regression: The horizontal space between days is much bigger than the vertical space. This looks strange and should be even. Meaning the datepicker should also grow taller.
- An enhancement: The circle around the current day should actually be circular (or pill-style) but not oval. Instead of
border-radius: 50%, useborder-radius: --border-radius-pill;(which is 100px) which will look much nicer.
With lots of flex love Also make middle "week" button round Fix stylelint warnings Fix arrow positions Fix JCB feedback Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
bug/fix-datepicker
branch
from
4350c12
to
0dc08e9
Compare
|
@jancborchardt Addressed. |
jancborchardt
approved these changes
Mar 17, 2019
georgehrke
approved these changes
Mar 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1043
Before
(latest release, without #1043 and round buttons)
After