-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve info.xml for new appstore #123
Conversation
@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tcitworld and @janklostermann to be potential reviewers. |
<namespace>Calendar</namespace> | ||
<author homepage="https://georg.coffee">Georg Ehrke</author> | ||
<author homepage="http://raghunayyar.com">Raghu Nayyar</author> | ||
<author>Thomas Citharel</author> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You Can put https://tcit.fr even if this is not live.
👍 |
63b2894
to
5e48cf7
Compare
<id>calendar</id> | ||
<name>Calendar</name> | ||
<summary>Calendar GUI for Nextcloud's CalDAV server</summary> | ||
<description><![CDATA[The Nextcloud calendar app is a user interface for Nextcloud's CalDAV server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be rendered as markdown so indention will be treated as code blocks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
fixed it
<documentation> | ||
<user>https://docs.nextcloud.com/server/10/user_manual/pim/calendar.html</user> | ||
</documentation> | ||
<category>productivity</category> | ||
<website>https://github.com/nextcloud/calendar/</website> | ||
<bugs>https://github.com/nextcloud/calendar/issues</bugs> | ||
<discussion>https://help.nextcloud.com/</discussion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't validate. The idea is to link to an open thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, but why would you link to one particular thread?
All people commenting with their issues, questions and feature requests in one thread seems wrong to me.
How would you mark single questions as answered?
I would totally agree on a calendar category in our discourse though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one particular thread kinda mimics the old comment system on the old app store: it was just a continuous stream of comments and answers and I think that's fine for some use cases.
I like the idea for a separate category per app but I'd go for a convention like https://help.nextcloud.com/c/app-calendar (e.g. if there is no discussion xml element we change the link to a category).
The issue with this however is that a moderator needs to create that category first and I suppose scrolling through categories when each app has a separate one gets kinda messy. Still a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use /c/app/calendar, so it displays as a folder of categories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good idea. BTW we could just create that category serverside when you first register your app https://meta.discourse.org/t/discourse-api-documentation/22706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also cc @Henni
That approach would allow us to completely drop the discussion tag I think and not worry about the URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5e48cf7
to
3277f2c
Compare
3277f2c
to
f010e61
Compare
I ditched the discussion tag. |
please review @raghunayyar @BernhardPosselt @tcitworld