-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: when a attendee is a second person without email, skip alreadyInvitedEmails check #2977
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
=========================================
Coverage 23.67% 23.67%
Complexity 457 457
=========================================
Files 249 249
Lines 11774 11774
Branches 2214 2204 -10
=========================================
Hits 2788 2788
- Misses 8668 8669 +1
+ Partials 318 317 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -186,7 +186,7 @@ export default { | |||
name = email | |||
} | |||
|
|||
if (this.alreadyInvitedEmails.includes(email)) { | |||
if (this.alreadyInvitedEmails.includes(email) && email) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but now it skips the attendee if it has an email, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. If user has email, he/she only skip when this.alreadyInvitedEmails.includes(email) === true, and skip all users don't have email.
I updated the condition check order in latest commit, maybe this looks more intuitive.
if (email && this.alreadyInvitedEmails.includes(email)) {
return
}
In country like China, a lot of people don't have email, so updated this :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic sounds good, didn't test
/backport to stable4.7 |
In case if multiple attendees have empty email, the second one won't show in search result by
block of alreadyInvitedEmails. Add email is not empty check in findAttendeesFromContactsAPI