-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore original event ordering #5786
Conversation
This needs to be tested thoroughly to avoid a regression. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5786 +/- ##
============================================
+ Coverage 23.73% 23.75% +0.01%
Complexity 423 423
============================================
Files 244 244
Lines 11223 11224 +1
Branches 1862 1863 +1
============================================
+ Hits 2664 2666 +2
+ Misses 8559 8558 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing with data similar to the original PR and added some screenshots.
It works fine again with the original order.
b6476f6
to
ded1f29
Compare
The underlying issue has been fixed upstream.
This reverts:
Have a look at the screenshots below. Note that
Expanded
Before
After
Limited
Before
After