Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore original event ordering #5786

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 21, 2024

The underlying issue has been fixed upstream.

This reverts:

Have a look at the screenshots below. Note that

  1. All events are shown in both before and after screenshots -> no regressions introduced
  2. The events are ordered by name again -> old/original sort order restored

Expanded

Before

before

After

after

Limited

Before

before-limited

After

after-limited

@st3iny st3iny added 2. developing Work in progress bug labels Feb 21, 2024
@st3iny st3iny self-assigned this Feb 21, 2024
@st3iny
Copy link
Member Author

st3iny commented Feb 21, 2024

This needs to be tested thoroughly to avoid a regression.

ChristophWurst
ChristophWurst previously approved these changes Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (f0cbecc) to head (ded1f29).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5786      +/-   ##
============================================
+ Coverage     23.73%   23.75%   +0.01%     
  Complexity      423      423              
============================================
  Files           244      244              
  Lines         11223    11224       +1     
  Branches       1862     1863       +1     
============================================
+ Hits           2664     2666       +2     
+ Misses         8559     8558       -1     
Flag Coverage Δ
javascript 14.78% <ø> (+0.02%) ⬆️
php 61.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The underlying issue has been fixed upstream.

This reverts:
- c5b5f16 (#4431)
- 5334250 (#4646)

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Copy link
Member Author

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing with data similar to the original PR and added some screenshots.

It works fine again with the original order.

@st3iny st3iny requested review from tcitworld and GretaD March 18, 2024 08:58
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 18, 2024
@st3iny st3iny marked this pull request as ready for review March 18, 2024 08:58
@st3iny st3iny force-pushed the fix/restore-event-reordering branch from b6476f6 to ded1f29 Compare March 18, 2024 08:59
@st3iny st3iny merged commit ffa02bd into main Mar 18, 2024
39 checks passed
@st3iny st3iny deleted the fix/restore-event-reordering branch March 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Development

Successfully merging this pull request may close these issues.

2 participants