Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Update to Material Symbol #6054

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

AndyScherzinger
Copy link
Member

Replace all app icon work with Material Symbol version in alignment with @jancborchardt

@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. labels Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.60%. Comparing base (75445bd) to head (5ef3463).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6054   +/-   ##
=========================================
  Coverage     23.60%   23.60%           
  Complexity      457      457           
=========================================
  Files           246      246           
  Lines         11716    11716           
  Branches       2150     2151    +1     
=========================================
  Hits           2766     2766           
  Misses         8635     8635           
  Partials        315      315           
Flag Coverage Δ
javascript 15.18% <ø> (ø)
php 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala added this to the v4.8.0 milestone Jun 11, 2024
@AndyScherzinger
Copy link
Member Author

@miaulalala any hints on how to get the checks from red to green? 🙏

@miaulalala
Copy link
Contributor

Let's see if a rebase does it

@AndyScherzinger
Copy link
Member Author

@miaulalala nope, cause any other recent PR fails on the same checks, i.e. #6056

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@miaulalala miaulalala merged commit 9278032 into main Jun 13, 2024
43 checks passed
@miaulalala miaulalala deleted the style/noid/materialSymbol branch June 13, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants