Quickfix for sidebar on NC14

[tcitworld]

Closes #876

I didn't test on NC < 14, but it should be fine since it only puts back
old sidebar behaviour before nextcloud/server#10218

[tcitworld]

Maybe @skjnldsv can leave some input on how to handle position: sticky; better instead of returning to position: fixed as I did ? :)
The issue is that the editor panel is inside a popup over the content, not aside it.

[skjnldsv]

@tcitworld sure, position sticky is the same as fixed instead in is based on the parent scrolling position.
Currently, the first scrollable parent is body, so you just need to make sure you don't add any overflow to any parent the sticky element have.

Nonetheless, since the calendar don't have any scrollable area? (right?)
Sticky shouldn't change anything I think. Let me have a look :)

[skjnldsv]

Ah, the layout is not ok, the sidebar is supposed to be right next to the content
nextcloud/server#9982

[tcitworld]

Nonetheless, since the calendar don't have any scrollable area? (right?)

Will have to check on that. :/

Ah, the layout is not ok, the sidebar is supposed to be right next to the content

That's the issue I mentioned earlier with

The issue is that the editor panel (sidebar) is inside a popup over the content, not aside it.

I think it's because reducing the calendar's width makes it quite ugly that it's like that. Do you think the sidebar panel can be put aside and still get over the main content ?

I'll try to have a look on how other apps did with nextcloud/server#9982.

[skjnldsv]

@tcitworld the calendar is a bit aside from the others app :)
Maybe just add a manual fixed override like you did then.
Just comply to the first layout where only app-content is needed and not the #app one :)
See the contacts hack we did (since the new update won't have the same behavior, this is just a quick fix) https://github.com/nextcloud/contacts/blob/master/js/contacts-inject-14.js

[tcitworld]

Need to review after #882 is merged.

[georgehrke]

rebased

[georgehrke]

The position itself is fixed, but for me Friday, Saturday and Sunday are hidden behind the sidebar now. The calendar-grid should adjust its width

[georgehrke]

@skjnldsv Do you know what change in the server caused this?
The behavior in the files app is correct. (if sidebar opens, width of filelist adapts)

[skjnldsv]

@georgehrke because the sidebar is not fixed anymore. It's inline flexed with the content.
If you do this, the calendar will be under the sidebar! :)
Which is OK of course if that's what you want! ;)

[skjnldsv]

Imho i feel like it's easier to always see the content. Let say for example that you're editing an event but want to check another one on the next sunday to make sure you're available this date. :)

[georgehrke]

@skjnldsv Would you mind looking into this? It's probably just two or three lines of css.

[skjnldsv]

It's probably just two or three lines of css.

It's never that easy 😁
The app sidebar is not on the right location according to the standard, but seeing the overall layout, it would be far too hard to change everything.
This patch works fine, let's merge this for 14 and make sure the update to vue fit the new structure guidelines.

Please update review again :)

[georgehrke]

Roger that!