-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timezone property to newly created calendars #886
Conversation
Closes #223 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
js/app/service/calendarService.js
Outdated
@@ -303,6 +303,10 @@ app.service('CalendarService', function(DavClient, StringUtility, XMLUtility, Ca | |||
name: [DavClient.NS_DAV, 'd:displayname'], | |||
value: name | |||
}); | |||
dPropChildren.push({ | |||
name: [DavClient.NS_IETF, 'c:calendar-timezone'], | |||
value: TimezoneService.getDetected() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calendar-timezone
is supposed to contain the actual VTimezone
definition.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Not sure if CDATA element is to be used or not (SabreDAV tests has some, but it seems to be badly escaped on PROPFIND response). I've yet to find a CalDAV client that supports this to test it, can you try this on MacOS/iOS ? |
Yes, will do. |
|
No CDATA:
|
Closing in favour of #223 (comment) |
Closes #223
I didn't add the property on WebCal collections, not sure if applicable, but it's fairly easy to add it too.
Also, I didn't consider the case when someone updates his calendar but the timezone changed since the creation.