-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for bug that prevented editing vCards with commas in the address #1394
Conversation
Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
Codecov Report
@@ Coverage Diff @@
## master #1394 +/- ##
=======================================
Coverage 62.31% 62.31%
=======================================
Files 4 4
Lines 69 69
=======================================
Hits 43 43
Misses 26 26 Continue to review full report at Codecov.
|
As mentioned in #1393 (comment) |
Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
@hanzi FYI The PRs in |
This is a workaround that fixes #1009
(also fixes #1313)
Without it, contacts whose address contains a comma (quite common in Asian addresses) cannot be edited in the web interface.
I am aware that this is actually an upstream bug (kewisch/ical.js#386) and should be fixed there... but that PR is about 10 months old and it is unclear when it might be merged and tagged. Meanwhile, this leads to very poor user experience in the Contacts app.
This fix would not conflict with that upstream PR since it merely makes it explicit that
LABEL
cannot contain multiple values.