Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for bug that prevented editing vCards with commas in the address #1394

Merged
merged 4 commits into from
Jan 6, 2020

Conversation

hanzi
Copy link
Member

@hanzi hanzi commented Jan 4, 2020

This is a workaround that fixes #1009
(also fixes #1313)

Without it, contacts whose address contains a comma (quite common in Asian addresses) cannot be edited in the web interface.

I am aware that this is actually an upstream bug (kewisch/ical.js#386) and should be fixed there... but that PR is about 10 months old and it is unclear when it might be merged and tagged. Meanwhile, this leads to very poor user experience in the Contacts app.

This fix would not conflict with that upstream PR since it merely makes it explicit that LABEL cannot contain multiple values.

Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #1394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files           4        4           
  Lines          69       69           
=======================================
  Hits           43       43           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3803e4...72960f1. Read the comment docs.

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working labels Jan 6, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Jan 6, 2020

As mentioned in #1393 (comment)
Please put those patches in another dedicated file :)

Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
@hanzi
Copy link
Member Author

hanzi commented Jan 6, 2020

@skjnldsv I have now tried to re-use the existing flow for updating the design set and extracting it into its own service.

I will update #1393 once this is merged.

Signed-off-by: Christian Kraus <hanzi@hanzi.cc>
@skjnldsv skjnldsv merged commit 438e83e into nextcloud:master Jan 6, 2020
@hanzi hanzi deleted the fix-address-label-with-comma branch January 6, 2020 12:37
@hanzi hanzi restored the fix-address-label-with-comma branch January 6, 2020 12:37
@hanzi hanzi deleted the fix-address-label-with-comma branch January 6, 2020 12:37
@caugner
Copy link

caugner commented Jan 13, 2020

@hanzi FYI The PRs in ical.js have been merged, so the next ical.js version will include the fixes.

@skjnldsv skjnldsv added this to the next milestone Jan 18, 2020
@skjnldsv skjnldsv modified the milestones: next, 3.1.7-3.1.9 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
3 participants