Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: migrate to vite #3804

Merged
merged 1 commit into from
Jun 6, 2024
Merged

perf: migrate to vite #3804

merged 1 commit into from
Jun 6, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 8, 2024

Bundle sizes

Assets Before After
js 8,9M 3,6M
css 0 240K
total 8,9M 3,9M

@st3iny st3iny added the performance Performance issues and optimisations label Feb 8, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 2.12%. Comparing base (8c3a4f5) to head (969a264).
Report is 120 commits behind head on main.

Current head 969a264 differs from pull request most recent head 5a2d57d

Please upload reports for the commit 5a2d57d to get more accurate results.

Files Patch % Lines
src/files-action.js 0.00% 3 Missing and 1 partial ⚠️
src/main.js 0.00% 3 Missing ⚠️
lib/Controller/PageController.php 0.00% 2 Missing ⚠️
src/mixins/CircleActionsMixin.js 0.00% 2 Missing ⚠️
...nts/AppNavigation/Settings/SettingsAddressbook.vue 0.00% 1 Missing ⚠️
src/services/cdav.js 0.00% 1 Missing ⚠️
src/services/collaborationAutocompletion.js 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3804      +/-   ##
==========================================
- Coverage     2.44%   2.12%   -0.32%     
- Complexity       0     261     +261     
==========================================
  Files           90     114      +24     
  Lines         4541    5221     +680     
  Branches      1163    1130      -33     
==========================================
  Hits           111     111              
- Misses        4310    4990     +680     
  Partials       120     120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label May 2, 2024
@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels May 28, 2024
@st3iny st3iny force-pushed the perf/migrate-to-vite branch 2 times, most recently from d7a903a to c794d3d Compare May 30, 2024 06:30
@st3iny st3iny added this to the v6.1.0 milestone May 30, 2024
@st3iny st3iny marked this pull request as ready for review May 30, 2024 09:49
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 30, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

src/components/ContactDetails.vue Show resolved Hide resolved
templates/settings/admin.php Show resolved Hide resolved
@st3iny st3iny force-pushed the perf/migrate-to-vite branch 2 times, most recently from fd45cf5 to 425c026 Compare June 6, 2024 07:25
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny enabled auto-merge June 6, 2024 07:29
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 6, 2024
@st3iny st3iny merged commit 3f69106 into main Jun 6, 2024
26 checks passed
@st3iny st3iny deleted the perf/migrate-to-vite branch June 6, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish performance Performance issues and optimisations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants