Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark REV values as UTC (see #41) #65

Merged
merged 1 commit into from
Dec 29, 2016
Merged

Mark REV values as UTC (see #41) #65

merged 1 commit into from
Dec 29, 2016

Conversation

rfc2822
Copy link
Contributor

@rfc2822 rfc2822 commented Dec 21, 2016

No description provided.

@skjnldsv
Copy link
Member

We need to be sure we're following rfc 3339

Z           A suffix which, when applied to a time, denotes a UTC
            offset of 00:00; often spoken "Zulu" from the ICAO
            phonetic alphabet representation of the letter "Z".

https://www.ietf.org/rfc/rfc3339.txt

@skjnldsv skjnldsv added 2. developing Work in progress bug Something isn't working labels Dec 22, 2016
@zeehio
Copy link

zeehio commented Dec 22, 2016

I am all for the "Z".

Dropping the milliseconds does not go against the rfc3339. In fact:

5.3. Rarely Used Options

   A format which includes rarely used options is likely to cause
   interoperability problems.  This is because rarely used options are
   less likely to be used in alpha or beta testing, so bugs in parsing
   are less likely to be discovered.  Rarely used options should be made
   mandatory or omitted for the sake of interoperability whenever
   possible.

   The format defined below includes only one rarely used option:
   fractions of a second.  It is expected that this will be used only by
   applications which require strict ordering of date/time stamps or
   which have an unusual precision requirement.

So either there is a rationale for keeping milliseconds or we avoid them.

@skjnldsv skjnldsv merged commit ccb2707 into nextcloud:master Dec 29, 2016
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Dec 29, 2016
@skjnldsv skjnldsv modified the milestone: 1.5.3 Dec 29, 2016
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews labels Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants