Fix #2384: Fix import of WP Recipe Maker recipes #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2024 12:08
I want to import recipes from a site that uses WordPress Recipe Maker
At least on this site, the schema is structured like so:
{
"@Schema": "https://schema.org/",
"@graph": [
{ /* blah */ },
{ /* blah */ },
{ "@type": "Recipe", "otherStuff": True }
]
}
Notably missing is the @Schema on the Recipe object. It's intended
to be inherited from the parent, but HttpJsonLdParser didn't support
this kind of inheritance.
Well, now it does! =)
Signed-off-by: Nathaniel <I@nathaniel.land>
Following the update to the parser to support inheriting the schema declaration from the root object to the recipe object, add a test that exercises this new functionality. Signed-off-by: Nathaniel <I@nathaniel.land>
Test Results 12 files 584 suites 1m 35s ⏱️ Results for commit fc29da7. ♻️ This comment has been updated with latest results. |
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Reported by psalm upon pushing Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
approved these changes
Jun 26, 2024
Signed-off-by: Christian Wolf <github@christianwolf.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Many recipe websites are built with WordPress Recipe Maker with Yoast SEO exposing the recipe as a parseable
schema. This combination presented a schema which the recipe extractor did not handle properly.
This PReq makes a small modification to the parser logic to support this new schema format, and adds a test
exercising the new functionality.
I have found several sites that previously failed to parse, and now parse successfully. I believe this update
resolves the issue with most WordPress Recipe Maker websites, and it definitely resolves the parsing failure
on the site referenced in #2384.
Concerns/issues
The tests do not detect any regressions from this change, and I do not expect the change to be a significant
risk of causing regressions.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.