Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not ignore return value #4998

Merged
merged 1 commit into from
Oct 11, 2022
Merged

do not ignore return value #4998

merged 1 commit into from
Oct 11, 2022

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Oct 2, 2022

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #4998 (db2394f) into master (42f6a63) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head db2394f differs from pull request most recent head 74f3519. Consider uploading reports for the commit 74f3519 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4998      +/-   ##
==========================================
- Coverage   57.16%   56.97%   -0.20%     
==========================================
  Files         138      138              
  Lines       17401    17228     -173     
==========================================
- Hits         9947     9815     -132     
+ Misses       7454     7413      -41     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/vfs_cfapi.cpp 82.92% <100.00%> (-0.48%) ⬇️
src/libsync/abstractnetworkjob.h 27.27% <0.00%> (-18.19%) ⬇️
src/libsync/account.h 29.41% <0.00%> (-3.93%) ⬇️
src/libsync/syncfileitem.h 37.50% <0.00%> (-2.16%) ⬇️
src/libsync/abstractnetworkjob.cpp 72.61% <0.00%> (-1.99%) ⬇️
src/libsync/propagateremotemkdir.cpp 64.53% <0.00%> (-0.50%) ⬇️
src/libsync/syncfileitem.cpp 94.54% <0.00%> (-0.37%) ⬇️
src/common/syncjournaldb.cpp 77.42% <0.00%> (-0.22%) ⬇️
src/libsync/bulkpropagatorjob.cpp 73.10% <0.00%> (-0.15%) ⬇️
... and 6 more

@mgallien mgallien force-pushed the ci/removeOneWarningOnWindows branch 2 times, most recently from 16c92d0 to db2394f Compare October 3, 2022 20:06
@mgallien mgallien force-pushed the ci/removeOneWarningOnWindows branch from db2394f to 77a44ca Compare October 6, 2022 12:11
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4998-74f35191e0e78eb6df4527c299b28fc469bc8066-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mgallien mgallien merged commit bde2f90 into master Oct 11, 2022
@mgallien mgallien deleted the ci/removeOneWarningOnWindows branch October 11, 2022 21:48
@mgallien mgallien added this to the 3.7.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants