when moving a file, checks that it exists at origin or destination #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bugfix/multipleMovesOfASingleFileid
branch
2 times, most recently
from
92f3fc4
to
7a7926e
Compare
|
/backport to stable-3.12 |
current automated tests are never breaking the rule that a file that should be moved on client side (after a move was done server side) exists either at teh original path or the destination path. in practice it may happen (and I manually tested it) thet the sync engine decides to move a single file in two distinct places that decision will violate this rule and a debug build would then run into the assert Close #6462 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
this new test trigger the assert that a file is either in the old place or the new place when we execute a MOVE instruction for a local file in the test one file is discovered as in need of a local MOVE but will be missing from the old and new places when running the propagation due to a bug Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/multipleMovesOfASingleFileid
branch
from
7a7926e
to
8f8646f
Compare
camilasan
approved these changes
Mar 5, 2024
allexzander
reviewed
Mar 5, 2024
allexzander
reviewed
Mar 5, 2024
will fix mishandling of rename of a single file to multiple places during discovery Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/multipleMovesOfASingleFileid
branch
from
8f8646f
to
b7c1a95
Compare
|
AppImage file: nextcloud-PR-6463-b7c1a95d1cb3ba7800e79f8272d065eb674e9f54-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent double MOVE instructions for a single file by fixing one place that forgot to track such MOVE instructions
add an automated test to reproduce teh error scenario
add a fix for the wrong behavior
to prevent the issue from coming back also add an assert ensuring a moved file exists
Close #6462