Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add daily update channel. #6658

Merged
merged 16 commits into from
Jul 3, 2024
Merged

Add daily update channel. #6658

merged 16 commits into from
Jul 3, 2024

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Apr 22, 2024 •
edited
Loading

Client updater: nextcloud/client_updater_server#144
Infrastructure: https://github.com/nextcloud-gmbh/internal-infrastructure/pull/416

  • Adds the daily and enterprise option to the update url:
    channel=daily

  • Changes the message box test when the user switches update channels:

    • before:
      update-channel-before
    • after:
      update-channel-after

  • Test:

    • Linux
    • mac OS
    • Windows

  • ⚠️ The updater site backend part needs to be implement

@camilasan camilasan marked this pull request as ready for review April 23, 2024 17:58
@camilasan camilasan marked this pull request as draft April 23, 2024 18:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan camilasan force-pushed the feature/update-channel branch 2 times, most recently from fca12f6 to a133d1a Compare June 3, 2024 19:14
@camilasan camilasan marked this pull request as ready for review June 3, 2024 19:14
@camilasan camilasan force-pushed the feature/update-channel branch 2 times, most recently from 180edbe to 031319f Compare June 3, 2024 19:25
This was referenced Jun 3, 2024
Merged
Closed
@camilasan camilasan changed the title Add new update channels. Add daily update channels. Jun 3, 2024
nimishavijay
nimishavijay requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment •
edited by camilasan
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement! :) Love the bullet points, they make things so much more clear. The wording is also way more concise!
I would suggest only a few minor changes

- stable: contains tested versions considered reliable
- beta: contains versions with new features that may not be tested thoroughly
- daily: contains versions created daily only for testing and development

Downgrading versions is not possible immediately: changing from beta to stable means waiting for the new stable version.

As a follow up, I would propose some more changes:

  • on the settings page, the channels could be in radio buttons instead of in a dropdown.
  • that way we could move the channel info directly onto the settings page
  • change the confirmation dialog to show only the "downgrading is not possible" message
  • show the confirmation dialog only when changing from daily to beta or beta to stable

What do you think :)

@tobiasKaminsky tobiasKaminsky linked an issue Jun 4, 2024 that may be closed by this pull request
Daily channel #5807
Closed
@Mika-6-9
Copy link

Mika-6-9 commented Jun 4, 2024

It's a really good idea, why only tests on Linux?
We can test on Windows if you need testers.

How will the enterprise (stable) versions be validated?

@camilasan
Copy link
Member Author

camilasan commented Jun 27, 2024 •
edited
Loading

* that way we could move the channel info directly onto the settings page

where would the text go?

@nimishavijay
Copy link
Member

@camilasan looks great! I would only recommend that it's in a vertical arrangement instead of horizontal :)

@camilasan camilasan changed the title Add daily update channels. Add daily update channel. Jul 2, 2024
@camilasan camilasan mentioned this pull request Jul 2, 2024
Draft
7 tasks
@camilasan
Copy link
Member Author

@camilasan looks great! I would only recommend that it's in a vertical arrangement instead of horizontal :)

I will address this in #6873

mgallien
mgallien requested changes Jul 3, 2024
View reviewed changes
src/gui/generalsettings.cpp Outdated Show resolved Hide resolved
src/gui/generalsettings.cpp Outdated Show resolved Hide resolved
src/gui/updater/updater.cpp Outdated Show resolved Hide resolved
src/libsync/configfile.cpp Outdated Show resolved Hide resolved
@camilasan
Add daily update channel.
60174c6 
- Set update channel options list in slotUpdateInfo.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Modernize ConfigFile::updateChannel and Updater::getQueryParams.
e2f71e6 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Adds info about daily builds to message shown if user changes update …
82f27e0 
…channel.

- Also makes the explanation more concise.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Clean up code in GeneralSettings.
d82608d 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
List daily update channel in the general settings view.
2ac3b69 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Change the default MIRALL_VERSION_SUFFIX from "git" to "daily".
a4f6aec 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Use the value from MIRALL_VERSION_SUFFIX as the default update channel.
07f31f7 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Add versionSuffix function to Theme.
3f9bf0a 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Enforce the update channel based on the current client installed.
eb8b775 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Improve text displayed when user switches update channel.
5f0c74d 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Remove commented out line.
fbadd55 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Rename var in configfile.
364b329 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Use default in switch.
f581aa1 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Use only const auto in obvious pointer.
e5c2c8f 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Remove unused updatesegment option from updater query.
13b7c53 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
Enable RVO (return value optimization).
4de3107 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6658-4de310738309b8b61c9495674f00966fd968689a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
20 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan camilasan merged commit ba9b340 into master Jul 3, 2024
12 of 14 checks passed
@camilasan camilasan deleted the feature/update-channel branch July 3, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay requested changes

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daily channel
5 participants
@camilasan @Mika-6-9 @nimishavijay @nextcloud-desktop-bot @mgallien