Fix broken tray GUI on Linux #6798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
added
bug
high
os: 🐧 Linux
feature: ☁️ system tray
|
/backport to stable-3.13 |
8 tasks
camilasan
reviewed
Jun 6, 2024
| @@ -640,7 +640,7 @@ ApplicationWindow { | |||
| id: trayWindowTalkButton | |||
|
|
|||
| visible: UserModel.currentUser && UserModel.currentUser.serverHasTalk | |||
| icon.source: "qrc:///client/theme/white/talk-app.svg" | |||
| icon.source: "image://svgimage-custom-color/talk-app.svg" + "/" + Style.currentUserHeaderTextColor | |||
There was a problem hiding this comment.
We are using the svg image provider in order to be able to recolor the button icons however we want directly
camilasan
approved these changes
Jun 6, 2024
… image provider Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ernal properties Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ult size Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/kde-qml
branch
from
e99fab0
to
d61a209
Compare
|
AppImage file: nextcloud-PR-6798-d61a209e532c106712c1853f0c94e43482d3d750-x86_64.AppImage |
3 tasks
|
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant amount of our tray components are borked on Plasma. Not reproducible with AppImage, but can be reproduced when running the client non-containerised on Plasma. This PR fixes them
After fix:
Before fix:
Fixes #6729