Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EN] l10n: Add currency names to Transifex #147

Closed
Valdnet opened this issue Feb 11, 2022 · 23 comments
Closed

[EN] l10n: Add currency names to Transifex #147

Valdnet opened this issue Feb 11, 2022 · 23 comments
Assignees
@baimard
Labels
Country adaptation Wait for other issue

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Feb 11, 2022

I suggest adding currency names to Transifex so that they appear translated for the user.

obraz
@baimard
Copy link
Owner

baimard commented Feb 12, 2022 •
edited
Loading

I don't know how to do that (one big block to translate, or multiple lines) and maybe that cause big work for transifex translators ...

@rakekniven What do you think about that ?

@baimard baimard self-assigned this Feb 12, 2022
@Valdnet
Copy link
Contributor Author

Valdnet commented Feb 12, 2022

The translators can handle it 😁.
We have already translated all the names of languages and regions, the translators will also be able to translate the names of currencies 😉.

@baimard
Copy link
Owner

baimard commented Feb 12, 2022

So why not, big work in prevision for me and after for the Transifex community :)

@baimard baimard removed the need info label Feb 12, 2022
@rakekniven
Copy link
Contributor

Hello, I vote against to make this translatable.
How many times do you need to have listed currencies in your own language?

@baimard
Copy link
Owner

baimard commented Feb 12, 2022

I don't know, but I need to have listed in english for transifex no ?

SO I will translate all in english and add translation capabilitie with the function.

@rakekniven
Copy link
Contributor

You can have it listed in your app without translation.
If you will add it for translation please make it one line for each currency.

@rakekniven
Copy link
Contributor

Forgot to ask you another thing: Where did you get the list of currencies from?

@baimard
Copy link
Owner

baimard commented Feb 12, 2022

You can have it listed in your app without translation. If you will add it for translation please make it one line for each currency.

We discuss about translation in transifex of this list, and I ask you if it's an good idea :)

Forgot to ask you another thing: Where did you get the list of currencies from?

random link in google ...

@rakekniven
Copy link
Contributor

Actually there is no app in the nextcloud universe like yours regarding currencies.

Like stated in a previous post I would vote to not translate that list of currencies.

If it gets necessary in the future I strongly recommend to use international standards like ISO 4217 . See https://en.wikipedia.org/wiki/ISO_4217

@baimard
Copy link
Owner

baimard commented Feb 12, 2022

This subject need to be discuss :)

@Valdnet
Copy link
Contributor Author

Valdnet commented Feb 13, 2022 •
edited
Loading

If the application is fully translated, the currency should also be translated. Let me give you an example: If the application was in Chinese, we translate all text strings and leave the currency untranslated. I am curious how the users will choose their currency in Chinese.

If it gets necessary in the future I strongly recommend to use international standards like ISO 4217 .

👍

@baimard Also pay attention to this: #60 (comment).

@baimard
Copy link
Owner

baimard commented Feb 13, 2022

Please open a New issue

@rakekniven
Copy link
Contributor

Ok, arguments sounds valid.

As long as list is based on standards I am happy.

@baimard
Copy link
Owner

baimard commented Feb 14, 2022

Oh @rakekniven in fact if you go to src/js/modules/list.mjs you can see the list of country.

After reading the ISO 4217 standard, I realized that my list was good and that it is based on this standard :)

So I will start the transifex translation based on this ISO.

@baimard
Copy link
Owner

baimard commented Feb 23, 2022

Added

embeded in 2.0.6

I also wait for : nextcloud/docker-ci#355

baimard added a commit that referenced this issue Feb 23, 2022
@baimard
https://github.com/baimard/gestion/issues/147
6a57af2
baimard added a commit that referenced this issue Feb 27, 2022
@baimard @vitormattos
@nextcloud-bot @rakekniven @Valdnet
2.0.6 (#195)
ef5fa4f 
* refactoring

* refactoring

refactoring

refactoring & #46

Create help section for configuration and #47 #61

changelog

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* transifex

* transifex

* test

* Translation

* translation

* hotfix

* #123

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* #135

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* l10n: Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

* l10n: Improve styling

A more selected description of the function setting.

* l10n: Improve styling 

A more selected description of the function setting.

* l10n: Add "an"

* l10n: Add "an"

* l10n: Replace a word

* l10n: Replace a word

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Hotfix 2.0.2

* Hotfix 2.0.3

* enhancement tests !

* #143

* Postgresql

* NPM UPDATE

* #168

* #167

* #163

* #158

* #160

* #173

* Bug in configuration and delete confirmation message

* #142

* 2.0.5

* tests

* #53

#111

* #147

* test

* tests

* test

* test

* tests

* tests

* test

* for quote #179

* 2.0.6

Co-authored-by: Vitor Mattos <vitor@php.rio>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@baimard
Copy link
Owner

baimard commented Mar 10, 2022

nextcloud/docker-ci#362

@baimard
Copy link
Owner

baimard commented Mar 10, 2022

Done, lets go community !

@baimard baimard closed this as completed Mar 10, 2022
@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 10, 2022

Worse, when the community rebels on seeing so many currencies to translate 🤣.

@baimard
Copy link
Owner

baimard commented Mar 10, 2022

Where is the conversation ?

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 10, 2022

Relax, there is no conversation yet 😉.

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 10, 2022 •
edited
Loading

Translated 😁.

@baimard I have added issues in Transifex. You can see.

@baimard
Copy link
Owner

baimard commented Mar 10, 2022

You're a robot ...

baimard added a commit that referenced this issue Mar 11, 2022
@baimard @vitormattos
@nextcloud-bot @rakekniven @Valdnet
2.0.7 (#203)
4048f47 
* refactoring

* refactoring

refactoring

refactoring & #46

Create help section for configuration and #47 #61

changelog

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* transifex

* transifex

* test

* Translation

* translation

* hotfix

* #123

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* #135

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* l10n: Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

* l10n: Improve styling

A more selected description of the function setting.

* l10n: Improve styling 

A more selected description of the function setting.

* l10n: Add "an"

* l10n: Add "an"

* l10n: Replace a word

* l10n: Replace a word

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Hotfix 2.0.2

* Hotfix 2.0.3

* enhancement tests !

* #143

* Postgresql

* NPM UPDATE

* #168

* #167

* #163

* #158

* #160

* #173

* Bug in configuration and delete confirmation message

* #142

* 2.0.5

* tests

* #53

#111

* #147

* test

* tests

* test

* test

* tests

* tests

* test

* for quote #179

* 2.0.6

* pgsql

* fix length

* #154 && refactoring pur js

* refactoring jquery

* #190 #194

* #190 #194

* #194

* test protocole

* Test OK

* Fix after tests

Co-authored-by: Vitor Mattos <vitor@php.rio>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
baimard added a commit that referenced this issue Mar 15, 2022
@baimard @vitormattos
@nextcloud-bot @rakekniven @Valdnet
2.0.8 (#207)
da3670a 
* refactoring

* refactoring

refactoring

refactoring & #46

Create help section for configuration and #47 #61

changelog

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* transifex

* transifex

* test

* Translation

* translation

* hotfix

* #123

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* #135

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* l10n: Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

* l10n: Improve styling

A more selected description of the function setting.

* l10n: Improve styling 

A more selected description of the function setting.

* l10n: Add "an"

* l10n: Add "an"

* l10n: Replace a word

* l10n: Replace a word

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Hotfix 2.0.2

* Hotfix 2.0.3

* enhancement tests !

* #143

* Postgresql

* NPM UPDATE

* #168

* #167

* #163

* #158

* #160

* #173

* Bug in configuration and delete confirmation message

* #142

* 2.0.5

* tests

* #53

#111

* #147

* test

* tests

* test

* test

* tests

* tests

* test

* for quote #179

* 2.0.6

* pgsql

* fix length

* #154 && refactoring pur js

* refactoring jquery

* #190 #194

* #190 #194

* #194

* test protocole

* Test OK

* Fix after tests

* #206 and jquery remove

* hotfix 2.0.8

Co-authored-by: Vitor Mattos <vitor@php.rio>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
baimard added a commit that referenced this issue Mar 16, 2022
@baimard @vitormattos
@nextcloud-bot @rakekniven @Valdnet
2.0.8 (#212)
6625016 
* refactoring

* refactoring

refactoring

refactoring & #46

Create help section for configuration and #47 #61

changelog

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

[tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* transifex

* transifex

* test

* Translation

* translation

* hotfix

* #123

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* #135

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* Update lib/Migration/Version7Date20220125174818.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* l10n: Fixed grammar

Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

* l10n: Improve styling

A more selected description of the function setting.

* l10n: Improve styling 

A more selected description of the function setting.

* l10n: Add "an"

* l10n: Add "an"

* l10n: Replace a word

* l10n: Replace a word

* [tx-robot] updated from transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* Update lib/Migration/Version20002Date20220201085856.php

Co-authored-by: Vitor Mattos <vitor@php.rio>

* valide

* valide

* final

* Final

* Final

* Hotfix 2.0.2

* Hotfix 2.0.3

* enhancement tests !

* #143

* Postgresql

* NPM UPDATE

* #168

* #167

* #163

* #158

* #160

* #173

* Bug in configuration and delete confirmation message

* #142

* 2.0.5

* tests

* #53

#111

* #147

* test

* tests

* test

* test

* tests

* tests

* test

* for quote #179

* 2.0.6

* pgsql

* fix length

* #154 && refactoring pur js

* refactoring jquery

* #190 #194

* #190 #194

* #194

* test protocole

* Test OK

* Fix after tests

* #206 and jquery remove

* hotfix 2.0.8

* 2.0.8 Appinfo

Co-authored-by: Vitor Mattos <vitor@php.rio>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
@baimard
Copy link
Owner

baimard commented Mar 21, 2022

Translated in French :D very hard work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baimard baimard

Labels
Country adaptation Wait for other issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakekniven @baimard @Valdnet